SmartDukaan – /

Rev 36179 – weekly rating system live on calling module

ranu — Thu, 02 Apr 2026 23:22:40 +0530

ranu – 6 file(s) modified
weekly rating system live on calling module

~ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/enumuration/ActivationType.java
+ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/knowlarity/KnowlarityAgentInsightsService.java
~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/transaction/invoicing/InvoiceService.java
~ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/monitors/MonitorController.java
+ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/service/KnowlarityInsightsService.java
~ /trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/rbm_call_target.vm

Rev 36178 – Validate from/to items have same itemType in GRN correction request ...

amit — Thu, 02 Apr 2026 22:36:27 +0530

amit – 1 file(s) modified
Validate from/to items have same itemType in GRN correction request

Prevents GRN corrections between SERIALIZED and NON_SERIALIZED items which
would corrupt inventory data (e.g. assigning bulk qty to a serialized item
or vice versa). Validation runs at request submission time.

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/warehouse/PurchaseOrderServiceImpl.java

Rev 36177 – Fix currency format for negative amounts and use explicit symbol ...

amit — Thu, 02 Apr 2026 20:13:49 +0530

amit – 1 file(s) modified
Fix currency format for negative amounts and use explicit symbol removal

Previous regex fix missed negative amounts like -Rs.500.50. Now uses explicit
replace("Rs.", "") for Java 8 en_IN locale with ₹ fallback for newer JDKs.
Handles both positive (Rs.17,618.00) and negative (-Rs.500.50) correctly.

~ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/util/PdfUtils.java

Rev 36176 – Simplify invoice currency format fix for Java 8 compatibility ...

amit — Thu, 02 Apr 2026 20:11:23 +0530

amit – 1 file(s) modified
Simplify invoice currency format fix for Java 8 compatibility

Use single regex replaceFirst to strip any non-numeric prefix (Rs., ₹, etc.)
instead of getCurrency().getSymbol() which may return a different symbol than
what format() produces on Java 8.

~ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/util/PdfUtils.java

Rev 36175 – Fix leading dot in invoice currency formatting indianCurrencyFormat.format() produces ...

amit — Thu, 02 Apr 2026 20:10:11 +0530

amit – 1 file(s) modified
Fix leading dot in invoice currency formatting

indianCurrencyFormat.format() produces 'Rs.17,618.00' and the regex [^0-9,.]
was keeping the dot from 'Rs.' resulting in '.17,618.00'. Now strips the
currency symbol properly using getCurrency().getSymbol() with a fallback
regex to remove any remaining non-numeric prefix.

~ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/util/PdfUtils.java

Rev 36174 – Fix OOS false positive for dummy serialized items in warehouse ...

amit — Thu, 02 Apr 2026 20:04:04 +0530

amit – 1 file(s) modified
Fix OOS false positive for dummy serialized items in warehouse management

Serialized items without serial numbers (e.g. dummy items with bulk qty) were
always classified as out-of-stock because the ageing query requires
currentQuantity=1 and a serial number join. Added fallback to scan-based
availability check when ageing returns empty, so items with physical stock
correctly show as in-stock.

~ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/warehouse/OrderManagementController.java

Rev 36173 – Fix second QR NPE for DCs in getInvoicePdfModel — same ...

amit — Thu, 02 Apr 2026 19:32:50 +0530

amit – 1 file(s) modified
Fix second QR NPE for DCs in getInvoicePdfModel — same DC skip needed in both QR code paths

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/transaction/invoicing/InvoiceService.java

Rev 36172 – Skip IRN/QR code generation for DC challans in PDF - ...

amit — Thu, 02 Apr 2026 19:23:28 +0530

amit – 1 file(s) modified
Skip IRN/QR code generation for DC challans in PDF - DCs have no IRN, null QR was causing NPE

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/transaction/invoicing/InvoiceService.java

Rev 36171 – Handle GSP102 auth token expired/missing: evict cache and retry, same ...

amit — Thu, 02 Apr 2026 19:06:35 +0530

amit – 1 file(s) modified
Handle GSP102 auth token expired/missing: evict cache and retry, same as GSP752

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/gstpro/GstProService.java

Rev 36170 – Prevent infinite API retry loop: set irn_generated=false on any saveInvoice ...

amit — Thu, 02 Apr 2026 18:57:58 +0530

amit – 1 file(s) modified
Prevent infinite API retry loop: set irn_generated=false on any saveInvoice failure, remove hardcoded RF filter

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/transaction/invoicing/InvoiceService.java

Rev 36169 – Fix NonUniqueResult for duplicate serial numbers: use latest inventory entry ...

amit — Thu, 02 Apr 2026 18:56:08 +0530

amit – 1 file(s) modified
Fix NonUniqueResult for duplicate serial numbers: use latest inventory entry for refurbished items

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/repository/warehouse/WarehouseInventoryItemRepositoryImpl.java

Rev 36168 – Add EWB GET APIs (GetEwayBillsByDate, GetEwayBill), fix irn_generated for existing ...

amit — Thu, 02 Apr 2026 18:37:37 +0530

amit – 4 file(s) modified
Add EWB GET APIs (GetEwayBillsByDate, GetEwayBill), fix irn_generated for existing EWB, fetch+update script

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/gstpro/GstProService.java
+ /trunk/profitmandi-dao/src/test/java/com/spice/profitmandi/service/integrations/gstpro/EwbFetchByDateTest.java
+ /trunk/profitmandi-dao/src/test/java/com/spice/profitmandi/service/integrations/gstpro/EwbProdLookupTest.java
~ /trunk/profitmandi-dao/src/test/java/com/spice/profitmandi/service/integrations/gstpro/EwbSandboxTest.java

Rev 36167 – DC challans: use challan number as IRN, skip ack/qr/ack_date (not ...

amit — Thu, 02 Apr 2026 17:42:30 +0530

amit – 1 file(s) modified
DC challans: use challan number as IRN, skip ack/qr/ack_date (not applicable for DCs)

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/gstpro/GstProService.java

Rev 36166 – Add standalone EWB sandbox test — validates Part A only, ...

amit — Thu, 02 Apr 2026 17:33:50 +0530

amit – 3 file(s) modified
Add standalone EWB sandbox test — validates Part A only, 604 handling, and response fields

+ /trunk/profitmandi-dao/src/test/java/com/spice/profitmandi/service/integrations
+ /trunk/profitmandi-dao/src/test/java/com/spice/profitmandi/service/integrations/gstpro
+ /trunk/profitmandi-dao/src/test/java/com/spice/profitmandi/service/integrations/gstpro/EwbSandboxTest.java

Rev 36165 – Handle EWB 604: return marker result since Chartered Info API ...

amit — Thu, 02 Apr 2026 17:27:57 +0530

amit – 1 file(s) modified
Handle EWB 604: return marker result since Chartered Info API has no doc-number lookup

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/gstpro/GstProService.java

Rev 36164 – Handle EWB 604 (already exists): fetch existing EWB via GETEWBBYDOCNO ...

amit — Thu, 02 Apr 2026 17:21:38 +0530

amit – 1 file(s) modified
Handle EWB 604 (already exists): fetch existing EWB via GETEWBBYDOCNO instead of failing

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/gstpro/GstProService.java

Rev 36163 – Skip EWB for same-pincode DC transfers (virtual warehouse, no physical ...

amit — Thu, 02 Apr 2026 17:17:10 +0530

amit – 1 file(s) modified
Skip EWB for same-pincode DC transfers (virtual warehouse, no physical movement)

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/gstpro/GstProService.java

Rev 36162 – Fix standalone EWB for courier DCs: send Part A only ...

amit — Thu, 02 Apr 2026 17:08:01 +0530

amit – 1 file(s) modified
Fix standalone EWB for courier DCs: send Part A only without transMode to avoid 303 error, fix transactionType 4->1

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/gstpro/GstProService.java

Rev 36161 – GRN correction: create PURCHASE scan when creating new non-serialized inventory ...

amit — Thu, 02 Apr 2026 16:50:40 +0530

amit – 1 file(s) modified
GRN correction: create PURCHASE scan when creating new non-serialized inventory item

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/warehouse/PurchaseOrderServiceImpl.java

Rev 36160 – changeList

ranu — Thu, 02 Apr 2026 16:26:33 +0530

ranu – 1 file(s) modified
changeList

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/transaction/invoicing/InvoiceService.java

Rev 36159 – code for socket snapshot

ranu — Thu, 02 Apr 2026 16:25:50 +0530

ranu – 1 file(s) modified
code for socket snapshot

~ /trunk/profitmandi-cron/src/main/java/com/smartdukaan/cron/scheduled/knowlarity/KnowlarityCallMonitorScheduler.java

Rev 36158 – GRN correction: reset initialQuantity on old inventory item to avoid ...

amit — Thu, 02 Apr 2026 15:43:50 +0530

amit – 1 file(s) modified
GRN correction: reset initialQuantity on old inventory item to avoid confusion

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/warehouse/PurchaseOrderServiceImpl.java

Rev 36157 – Fix GRN correction: create PO lineitem for target item when ...

amit — Thu, 02 Apr 2026 15:38:05 +0530

amit – 1 file(s) modified
Fix GRN correction: create PO lineitem for target item when not on PO, adjust old item quantity

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/warehouse/PurchaseOrderServiceImpl.java

Rev 36156 – DC EWB: generate Part A only for courier orders, skip ...

amit — Thu, 02 Apr 2026 15:21:36 +0530

amit – 1 file(s) modified
DC EWB: generate Part A only for courier orders, skip EWB when no transporter or vehicle available

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/gstpro/GstProService.java

Rev 36155 – Fix e-invoice/EWB retry loop: set irnGenerated on all failure paths, ...

amit — Thu, 02 Apr 2026 13:48:18 +0530

amit – 2 file(s) modified
Fix e-invoice/EWB retry loop: set irnGenerated on all failure paths, send email on errors, prevent infinite cron retries

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/gstpro/GstProService.java
~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/transaction/invoicing/InvoiceService.java

Rev 36154 – Fix GRN correction for non-serialized items: create invoice_item when target ...

amit — Thu, 02 Apr 2026 12:44:26 +0530

amit – 1 file(s) modified
Fix GRN correction for non-serialized items: create invoice_item when target item not on invoice, drop stale itemNumber copy

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/warehouse/PurchaseOrderServiceImpl.java

Rev 36153 – Switch downloadCN to generateInvoiceV2 with IRN/QR stamp for finance team ...

amit — Thu, 02 Apr 2026 12:36:43 +0530

amit – 1 file(s) modified
Switch downloadCN to generateInvoiceV2 with IRN/QR stamp for finance team CN downloads

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/transaction/CreditNoteServiceImpl.java

Rev 36152 – Feat:Request Panel for brand dealer registration,Admin panel for managing WOD ...

aman — Thu, 02 Apr 2026 12:13:18 +0530

aman – 19 file(s) modified
Feat:Request Panel for brand dealer registration,Admin panel for managing WOD request templates

+ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/entity/fofo/FinServiceDocument.java
+ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/entity/fofo/FinServiceRequest.java
+ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/entity/fofo/FinServiceTemplate.java
+ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/repository/fofo/FinServiceDocumentRepository.java
+ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/repository/fofo/FinServiceDocumentRepositoryImpl.java
+ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/repository/fofo/FinServiceRequestRepository.java
+ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/repository/fofo/FinServiceRequestRepositoryImpl.java
+ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/repository/fofo/FinServiceTemplateRepository.java
+ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/repository/fofo/FinServiceTemplateRepositoryImpl.java
~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/service/loiForm/LoiFormServiceImpl.java
~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/transaction/CreditNoteServiceImpl.java
+ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/FinServiceController.java
+ /trunk/profitmandi-fofo/src/main/webapp/resources/js/wod-request.js
+ /trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/fin-service
+ /trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/fin-service/fin-service-list.vm
+ /trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/fin-service/fin-service-panel.vm
+ /trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/fin-service/wod-template-edit.vm
+ /trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/fin-service/wod-template-list.vm
~ /trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/include-scripts.vm

Rev 36151 – Switch /credit-note/{id} to use generateInvoiceV2 for new clean PDF format

amit — Thu, 02 Apr 2026 12:03:24 +0530

amit – 1 file(s) modified
Switch /credit-note/{id} to use generateInvoiceV2 for new clean PDF format

~ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/OrderController.java

Rev 36150 – On IRN cancel within 24h: set order status INVOICE_CANCELLED(90), regenerate ...

amit — Thu, 02 Apr 2026 11:59:22 +0530

amit – 1 file(s) modified
On IRN cancel within 24h: set order status INVOICE_CANCELLED(90), regenerate PDF with CANCELLED stamp

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/gstpro/GstProService.java

Rev 36149 – Add INVOICE_CANCELLED(90) status for post-billing IRN cancellation within 24h

amit — Thu, 02 Apr 2026 11:55:37 +0530

amit – 1 file(s) modified
Add INVOICE_CANCELLED(90) status for post-billing IRN cancellation within 24h

~ /trunk/ThriftConfig/src/main/java/in/shop2020/model/v1/order/OrderStatus.java

Rev 36148 – Increase PrecDocDtls cap to 100 — NIC has no explicit ...

amit — Thu, 02 Apr 2026 11:44:21 +0530

amit – 2 file(s) modified
Increase PrecDocDtls cap to 100 — NIC has no explicit limit, covers all per-partner monthly invoices

Rev 36147 – Add original_invoice_number to credit_note for RETURNS type, increase PrecDocDtls cap ...

amit — Thu, 02 Apr 2026 11:38:31 +0530

amit – 4 file(s) modified
Add original_invoice_number to credit_note for RETURNS type, increase PrecDocDtls cap to 10

CreditNote entity: added originalInvoiceNumber field
PurchaseReturnServiceImpl: set originalInvoiceNumber on RETURNS CN
CreditNoteServiceImpl: increased invoice ref collection from 4 to 10
GstProService: increased PrecDocDtls limit from 4 to 10

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/entity/transaction/CreditNote.java
~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/gstpro/GstProService.java
~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/inventory/PurchaseReturnServiceImpl.java
~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/transaction/CreditNoteServiceImpl.java

Rev 36146 – Credit Note IRN generation for monthly margins and returns ...

amit — Thu, 02 Apr 2026 11:22:48 +0530

amit – 2 file(s) modified
Credit Note IRN generation for monthly margins and returns

GstProService:
- Overloaded generateCreditNoteIrn() accepting pre-built InvoicePdfModel + multiple invoice refs (up to 4 PrecDocDtls)

CreditNoteServiceImpl:
- issueMonthlyMarginsCN: generate CRN IRN before PDF, stamp IRN/QR on PDF
- Uses generateInvoiceV2 for CN PDF (new clean format)
- Collects distinct invoice references from margin models
- Non-fatal: IRN failure doesn't block CN generation

Rev 36145 – Credit Note label support: CREDIT NOTE DETAILS / CN No: ...

amit — Thu, 02 Apr 2026 11:22:09 +0530

amit – 1 file(s) modified
Credit Note label support: CREDIT NOTE DETAILS / CN No: for credit note documents

~ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/util/PdfUtils.java

Rev 36144 – Wire Credit Note on debit note refund — proper CN ...

amit — Wed, 01 Apr 2026 20:44:51 +0530

amit – 1 file(s) modified
Wire Credit Note on debit note refund — proper CN numbering and persistence

refundOrder(debitNoteId):
- Generate CN number via SellerWarehouse.creditNoteSequence (CN-{prefix}{seq})
- Persist CreditNote record (type=RETURNS) in transaction.credit_note
- Persist CreditNoteLine per returned item with tax rates from original order
- Generate CRN e-invoice IRN on NIC referencing original invoice
- Non-fatal: CN/IRN failure doesn't block the refund

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/inventory/PurchaseReturnServiceImpl.java

Rev 36143 – Wire Credit Note e-invoice generation on debit note refund ...

amit — Wed, 01 Apr 2026 20:36:30 +0530

amit – 1 file(s) modified
Wire Credit Note e-invoice generation on debit note refund

refundOrder(debitNoteId):
- After wallet refund and status updates, generate CRN e-invoice on NIC
- Credit Note number: CN-{debitNoteNumber}
- References original transaction invoice via PrecDocDtls
- Non-fatal: CRN failure doesn't block the refund
- Supports multiple CRNs per invoice (partial returns over time)

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/inventory/PurchaseReturnServiceImpl.java

Rev 36142 – Prevent duplicate SALE_RET scans — fix double wallet refund bug ...

amit — Wed, 01 Apr 2026 20:04:17 +0530

amit – 1 file(s) modified
Prevent duplicate SALE_RET scans — fix double wallet refund bug

receiveDebitNoteItems():
- Build alreadyReturnedSet from existing SALE_RET/DOA_IN/SALE_RET_UNUSABLE scans
- Serialized: throw exception if IMEI already returned against same order
- Non-serialized: include existing return count in over-return check

processInvoiceReturn():
- Same alreadyReturnedSet check — skip with warning if already returned

Prevents the bug where same IMEI is returned, re-sold, then returned again
against the original order causing duplicate wallet refund.

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/inventory/PurchaseReturnServiceImpl.java

Rev 36141 – Fix Credit Note: PrecDocDtls must be a list for NIC ...

amit — Wed, 01 Apr 2026 19:50:37 +0530

amit – 2 file(s) modified
Fix Credit Note: PrecDocDtls must be a list for NIC API. Sandbox verified all 3 flows: IRN generate, IRN cancel (within 24h), Credit Note CRN (past 24h)

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/gstpro/api/model/E_InvoiceCommon.java
~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/gstpro/GstProService.java

Rev 36140 – Handle IRN cancellation with 24h window + Credit Note fallback ...

amit — Wed, 01 Apr 2026 19:32:02 +0530

amit – 1 file(s) modified
Handle IRN cancellation with 24h window + Credit Note fallback

cancelInvoiceGst(invoiceNumber, reason, creditNoteNumber):
- Within 24h: cancel IRN directly (EWB auto-cancelled by NIC)
- Past 24h: generate Credit Note e-invoice (DocType=CRN) referencing original invoice
- DC invoices: cancel standalone EWB regardless of time

generateCreditNoteIrn(originalInvoice, creditNoteNo, reason):
- Same endpoint as IRN generation but DocType=CRN
- RefDtls.PrecDocDtls references original invoice number and date
- No EWB details in credit note
- IRN persisted in einvoice_details table

Sandbox verified: CRN generation works with DocType=CRN

~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/gstpro/GstProService.java