WebSVN RSS feed – SmartDukaanThu, 03 Sep 2026 12:10:23 +0530WebSVN 2.8.6-DEVenhttps://svn.smartdukaan.com/log.php?repname=SmartDukaan&path=%2Ftrunk%2Fprofitmandi-fofo%2Fsrc%2Fmain%2Fjava%2Fcom%2Fspice%2Fprofitmandi%2Fweb%2Foffercircular%2FProductNames.java&max=40& Tue, 18 Aug 2026 13:37:58 +0530amit<div><strong>amit – 23 file(s) modified</strong><br/>Move offer-circular ingest out of cron and into the portal<br /> <br /> The parse now runs in profitmandi-fofo, on a background thread, triggered by the<br /> upload that produced the document.<br /> <br /> Why: splitting one feature across two artifacts with independent deploy cadences<br /> cost a full day. fofo shipped, cron did not, and a valid upload sat in DRAFT with<br /> nothing on the server able to parse it - the deployed cron jar contained none of the<br /> ingest classes. One 9-page PDF a month never justified a batch tier, and the portal<br /> already ships two PDF stacks, so the isolation argument for keeping PDFBox out was<br /> weaker than it looked.<br /> <br /> - 13 parser classes move verbatim from com.smartdukaan.cron.offercircular to<br /> com.spice.profitmandi.web.offercircular. No logic changed.<br /> - CircularIngestScheduler becomes CircularIngestRunner: the @Scheduled(every 5 min)<br /> entry point and the offer.circular.ingest.enabled flag are gone, replaced by a<br /> single-threaded daemon executor. All claim, ingest and notification logic is<br /> unchanged.<br /> - Upload hands the document id to the runner AFTER COMMIT, not inline. The DRAFT row<br /> is written inside the request transaction; a worker starting immediately would race<br /> that commit, find nothing to claim and silently do nothing - which is precisely the<br /> stuck-on-DRAFT symptom this change removes.<br /> - The guarded claim is KEPT even though there is now one trigger. It still stops a<br /> double-submit, a second portal node, and a re-ingest racing an in-flight parse.<br /> - Re-ingest parses immediately instead of queueing for a scheduler.<br /> - The stall reaper runs when the review screen loads. There is no timer here any<br /> more, and a document stranded by a redeploy mid-parse only matters when somebody<br /> looks for it - which matters more now the parse lives in the web application.<br /> - tabula moves to this module with its exclusions intact, as does the<br /> dumpCircularClasspath helper the local ingest harness depends on.<br /> - Screen no longer claims "the ingest job runs every 5 minutes", which was untrue the<br /> moment cron stopped being the route; poll interval 15s -> 3s to match a parse that<br /> takes seconds. jsVersion 404 -> 405.<br /> - offer.circular.review.url added here, since the runner sends that email now.<br /> <br /> Verified: full ingest of the Aug'26 circular through the relocated code is identical<br /> to the reference - 239 offers, 663 products, 279 AUTO_EXACT, 361 benefits, 511<br /> tenures, 911 bank links. ProductNamesTest 11/11 in its new home.</div>~ /trunk/profitmandi-fofo/build.gradle<br />~ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/config/AppConfig.java<br />~ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/OfferCircularController.java<br />+ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/offercircular<br />+ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/offercircular/BankTextParser.java<br />+ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/offercircular/BenefitParser.java<br />+ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/offercircular/CatalogIndex.java<br />+ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/offercircular/CircularExtractor.java<br />+ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/offercircular/CircularIngestRunner.java<br />+ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/offercircular/CircularIngestService.java<br />+ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/offercircular/CircularRow.java<br />+ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/offercircular/FootnoteParser.java<br />+ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/offercircular/ProductAliases.java<br />+ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/offercircular/ProductMatcher.java<br />+ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/offercircular/ProductNames.java<br />+ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/offercircular/ScopeConfig.java<br />+ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/offercircular/SequenceRatio.java<br />+ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/offercircular/TenureParser.java<br />~ /trunk/profitmandi-fofo/src/main/resources/META-INF/dev.properties<br />~ /trunk/profitmandi-fofo/src/main/resources/META-INF/prod.properties<br />~ /trunk/profitmandi-fofo/src/main/webapp/resources/js/offer-circular-review.js<br />+ /trunk/profitmandi-fofo/src/test/java/com/spice/profitmandi/web/offercircular<br />+ /trunk/profitmandi-fofo/src/test/java/com/spice/profitmandi/web/offercircular/ProductNamesTest.java<br />https://svn.smartdukaan.com/revision.php?repname=SmartDukaan&path=%2Ftrunk%2Fprofitmandi-fofo%2Fsrc%2Fmain%2Fjava%2Fcom%2Fspice%2Fprofitmandi%2Fweb%2Foffercircular%2FProductNames.java&rev=37337https://svn.smartdukaan.com/revision.php?repname=SmartDukaan&path=%2Ftrunk%2Fprofitmandi-fofo%2Fsrc%2Fmain%2Fjava%2Fcom%2Fspice%2Fprofitmandi%2Fweb%2Foffercircular%2FProductNames.java&rev=37337