WebSVN RSS feed – SmartDukaanWed, 07 Oct 2026 19:35:34 +0530WebSVN 2.8.6-DEVenhttps://svn.smartdukaan.com/log.php?repname=SmartDukaan&path=%2Ftrunk%2Fprofitmandi-dao%2Fsrc%2Fmain%2Fjava%2Fcom%2Fspice%2Fprofitmandi%2Fservice%2Fwarehouse%2FInvoiceService.java&max=40& Thu, 24 Sep 2026 18:54:23 +0530amit<div><strong>amit – 10 file(s) modified</strong><br/>fix(movement): receive a movement invoice only against its own PO, stop auto-closing movements, cancel reduces the PO line<br /> <br /> - GRN: movement invoice resolves invoice -> orders -> transaction -> its own movement PO (or a receive-only PO<br /> from the billing warehouse); supplier/warehouse keyed at entry must match; scanned IMEIs must be the billed ones<br /> - Cancelling an unbilled movement order takes its qty off the PO line; PO CLOSED/PRECLOSED once nothing is open<br /> - reopenedAt removed (movements no longer auto-close); PO records createdBy<br /> - SupplierStateResolver: a supplier's state is derived from its GSTIN on save<br /> - sql: add_po_created_by (applied), drop_po_reopened_at (run AFTER fofo/cron/web deploy)</div>~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/entity/warehouse/WarehousePurchaseOrder.java<br />~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/repository/transaction/OrderRepositoryImpl.java<br />~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/warehouse/InvoiceService.java<br />~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/warehouse/InvoiceServiceImpl.java<br />~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/warehouse/PurchaseOrderServiceImpl.java<br />+ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/warehouse/SupplierStateResolver.java<br />+ /trunk/profitmandi-dao/src/main/resources/sql/add_po_created_by_20260924.sql<br />+ /trunk/profitmandi-dao/src/main/resources/sql/drop_po_reopened_at_20260924.sql<br />+ /trunk/profitmandi-dao/src/test/java/com/spice/profitmandi/service/warehouse<br />+ /trunk/profitmandi-dao/src/test/java/com/spice/profitmandi/service/warehouse/SupplierStateResolverTest.java<br />https://svn.smartdukaan.com/revision.php?repname=SmartDukaan&path=%2Ftrunk%2Fprofitmandi-dao%2Fsrc%2Fmain%2Fjava%2Fcom%2Fspice%2Fprofitmandi%2Fservice%2Fwarehouse%2FInvoiceService.java&rev=37769https://svn.smartdukaan.com/revision.php?repname=SmartDukaan&path=%2Ftrunk%2Fprofitmandi-dao%2Fsrc%2Fmain%2Fjava%2Fcom%2Fspice%2Fprofitmandi%2Fservice%2Fwarehouse%2FInvoiceService.java&rev=37769 Mon, 09 Feb 2026 23:56:47 +0530amit<div><strong>amit – 10 file(s) modified</strong><br/>Refactor GrnController and PurchaseOrderController: extract business logic into focused services and fix N+1 query performance issues<br /> <br /> - Create InvoiceService: invoice item CRUD, validation, vendor price matching<br /> - Create GrnRequestService: GRN request lifecycle, mismatch resolution state machine<br /> - Create DebitNoteService: debit note generation, PDF model building<br /> - Move PO amendment logic from PurchaseOrderController to PurchaseOrderService<br /> - Delegate generateDebitNote from PurchaseOrderServiceImpl to DebitNoteService<br /> - Thin GrnController from ~1215 to ~717 lines, remove 15 unused autowired dependencies<br /> - Thin PurchaseOrderController editPurchaseOrder from 40+ lines to 3 lines<br /> <br /> Performance fixes:<br /> - InvoiceServiceImpl.validateInvoiceDetail: batch item/vendor pricing/GST loading (4N+3 queries -> ~5)<br /> - DebitNoteServiceImpl: batch item loading in buildDebitNotePdfModel and generateDebitNote<br /> - GrnController.generateDebitNote: eliminate 2 redundant DB fetches<br /> - Replace 3x supplierRepository.selectAll() with targeted selectBySupplierIds()</div>+ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/warehouse/DebitNoteService.java<br />+ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/warehouse/DebitNoteServiceImpl.java<br />+ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/warehouse/GrnRequestService.java<br />+ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/warehouse/GrnRequestServiceImpl.java<br />+ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/warehouse/InvoiceService.java<br />+ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/warehouse/InvoiceServiceImpl.java<br />~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/warehouse/PurchaseOrderService.java<br />~ /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/warehouse/PurchaseOrderServiceImpl.java<br />~ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/warehouse/GrnController.java<br />~ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/warehouse/PurchaseOrderController.java<br />https://svn.smartdukaan.com/revision.php?repname=SmartDukaan&path=%2Ftrunk%2Fprofitmandi-dao%2Fsrc%2Fmain%2Fjava%2Fcom%2Fspice%2Fprofitmandi%2Fservice%2Fwarehouse%2FInvoiceService.java&rev=35716https://svn.smartdukaan.com/revision.php?repname=SmartDukaan&path=%2Ftrunk%2Fprofitmandi-dao%2Fsrc%2Fmain%2Fjava%2Fcom%2Fspice%2Fprofitmandi%2Fservice%2Fwarehouse%2FInvoiceService.java&rev=35716