SmartDukaan – /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/

Rev 37379 – Restore insurance lines on invoice PDFs dropped by the r37066 ...

amit — Fri, 21 Aug 2026 15:27:23 +0530

amit – 8 file(s) modified
Restore insurance lines on invoice PDFs dropped by the r37066 renderer refactor

The modular doc-generation extraction moved the item table into ItemsTableSection,
which iterates only DocumentData.items() -> model.getOrderItems(). The legacy
renderer also emitted a row per CustomInsurancePolicy (PdfUtils r36674, lines
241-261); that block was lost in the extraction and nothing consumed
getInsurancePolicies() any more.

Effect: an extended-warranty policy is not a catalog item, so it has no
fofo_order_item row. Insurance sold after the device sale gets its own invoice
whose only line is the policy, so the whole table came out empty and the totals
- which SummarySection derives from the table, not from FofoOrder.totalAmount -
printed as 0.00 / 'Zero Rupees Only' (e.g. HRJND1424/94). On a combined
device+insurance invoice the policy line vanished silently and the invoice total
and GST were understated by the premium. InsuranceController's insurer document
pack, whose model carries policies and no order items at all, hit an NPE.

Fold the policies in at DocumentData.items(), the single accessor every section
reads, so the fix covers all callers at once. Column mapping mirrors the legacy
renderer: quantity 1, no discount, taxable value repeated in the Rate column.
Only the applicable tax side is populated (CGST/SGST or IGST) rather than both
as the policy model carries them, matching how real order items are built, so
ItemsTableSection's taxAmount = cgst+sgst+igst stays correct on margin-scheme
invoices. With no policies the model's own list is returned untouched.

Tests: InsuranceInvoiceRenderTest asserts on extracted PDF text (insurance-only,
intra/inter-state GST split, combined invoice, and a no-insurance control), so it
holds on any machine unlike the pixel goldens; three golden baselines added.
Verified all 14 pre-existing golden fixtures render byte-identical before and
after.

Also set java.awt.headless=true on the test JVM: the golden harness rasterizes
through PDFBox, whose font handling calls
GraphicsEnvironment.getLocalGraphicsEnvironment() and made the forked JVM attach
to the macOS window server as a Foreground app, stealing focus on every run.
Test-only property, no effect on the built war.

~ /trunk/profitmandi-common/build.gradle
~ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/DocumentData.java
~ /trunk/profitmandi-common/src/test/java/com/spice/profitmandi/common/document/golden/GoldenInvoiceV2Test.java
+ /trunk/profitmandi-common/src/test/java/com/spice/profitmandi/common/document/golden/InsuranceInvoiceRenderTest.java
~ /trunk/profitmandi-common/src/test/java/com/spice/profitmandi/common/document/golden/PdfFixtures.java
+ /trunk/profitmandi-common/src/test/resources/golden/v2-insurance-combined-p0.png
+ /trunk/profitmandi-common/src/test/resources/golden/v2-insurance-only-inter-p0.png
+ /trunk/profitmandi-common/src/test/resources/golden/v2-insurance-only-p0.png

Rev 37220 – invoice logo changed

ranu — Tue, 04 Aug 2026 15:27:27 +0530

ranu – 4 file(s) modified
invoice logo changed

~ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/section/PartiesSection.java
~ /trunk/profitmandi-common/src/main/resources/sdlogo.png
+ /trunk/profitmandi-common/src/main/resources/sdlogoNew.png
+ /trunk/profitmandi-common/src/main/resources/sdlogoold.png

Rev 37066 – Modular invoice/note PDF generation: extract DocumentRenderer + reusable sections + ...

amit — Fri, 10 Jul 2026 19:55:22 +0530

amit – 60 file(s) modified
Modular invoice/note PDF generation: extract DocumentRenderer + reusable sections + two-axis tax abstraction out of PdfUtils (now thin shims); folded per-tax invoice columns; note Invoice-Ref + type detection; golden-image test harness

~ /trunk/profitmandi-common
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/DocumentData.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/DocumentDataAdapter.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/DocumentRenderer.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/PdfContext.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/section
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/section/FooterSection.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/section/HeaderSection.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/section/ItemsTableSection.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/section/PartiesSection.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/section/Section.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/section/SummarySection.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/Styles.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/support
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/support/Assets.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/support/CancelledStamp.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/support/Formatting.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/support/SectionHelpers.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/tax
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/tax/InterStateTaxColumns.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/tax/IntraStateTaxColumns.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/tax/TaxColumns.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/tax/TaxColumnsFactory.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/document/tax/TaxTotals.java
~ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/util/PdfUtils.java
+ /trunk/profitmandi-common/src/test
+ /trunk/profitmandi-common/src/test/java
+ /trunk/profitmandi-common/src/test/java/com
+ /trunk/profitmandi-common/src/test/java/com/spice
+ /trunk/profitmandi-common/src/test/java/com/spice/profitmandi
+ /trunk/profitmandi-common/src/test/java/com/spice/profitmandi/common
+ /trunk/profitmandi-common/src/test/java/com/spice/profitmandi/common/document
+ /trunk/profitmandi-common/src/test/java/com/spice/profitmandi/common/document/DocumentDataAdapterTest.java
+ /trunk/profitmandi-common/src/test/java/com/spice/profitmandi/common/document/golden
+ /trunk/profitmandi-common/src/test/java/com/spice/profitmandi/common/document/golden/GoldenCreditNoteTest.java
+ /trunk/profitmandi-common/src/test/java/com/spice/profitmandi/common/document/golden/GoldenDebitNoteTest.java
+ /trunk/profitmandi-common/src/test/java/com/spice/profitmandi/common/document/golden/GoldenInvoiceV1Test.java
+ /trunk/profitmandi-common/src/test/java/com/spice/profitmandi/common/document/golden/GoldenInvoiceV2Test.java
+ /trunk/profitmandi-common/src/test/java/com/spice/profitmandi/common/document/golden/GoldenPdfHarness.java
+ /trunk/profitmandi-common/src/test/java/com/spice/profitmandi/common/document/golden/PdfFixtures.java
+ /trunk/profitmandi-common/src/test/java/com/spice/profitmandi/common/document/golden/SampleDocumentGeneratorTest.java
+ /trunk/profitmandi-common/src/test/java/com/spice/profitmandi/common/document/tax
+ /trunk/profitmandi-common/src/test/java/com/spice/profitmandi/common/document/tax/TaxColumnsTest.java
+ /trunk/profitmandi-common/src/test/resources
+ /trunk/profitmandi-common/src/test/resources/golden
+ /trunk/profitmandi-common/src/test/resources/golden/cn-inter-p0.png
+ /trunk/profitmandi-common/src/test/resources/golden/cn-intra-p0.png
+ /trunk/profitmandi-common/src/test/resources/golden/dn-inter-p0.png
+ /trunk/profitmandi-common/src/test/resources/golden/dn-intra-p0.png
+ /trunk/profitmandi-common/src/test/resources/golden/dn-po-suppressed-p0.png
+ /trunk/profitmandi-common/src/test/resources/golden/v1-inter-p0.png
+ /trunk/profitmandi-common/src/test/resources/golden/v1-intra-p0.png
+ /trunk/profitmandi-common/src/test/resources/golden/v1-margin-p0.png
+ /trunk/profitmandi-common/src/test/resources/golden/v2-dc-p0.png
+ /trunk/profitmandi-common/src/test/resources/golden/v2-inter-p0.png
+ /trunk/profitmandi-common/src/test/resources/golden/v2-intra-p0.png
+ /trunk/profitmandi-common/src/test/resources/golden/v2-margin-p0.png
+ /trunk/profitmandi-common/src/test/resources/golden/v2-multiorder-p0.png
+ /trunk/profitmandi-common/src/test/resources/golden/v2-po-orderdate-p0.png