SmartDukaan – //trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/exception/

Rev 37490 – errors: separate business, integration and bug -- three failures logged ...

amit — Tue, 01 Sep 2026 12:20:10 +0530

amit – 3 file(s) modified
errors: separate business, integration and bug -- three failures logged three ways

Everything was logged identically: ERROR, titled 'Internal Server Error', and in
web stack-traced twice (log4j2 plus printStackTrace, the second copy landing in
catalina.out). A partner mistyping an IMEI produced the same output as a
NullPointerException.

That makes the error stream unalertable. Measured over six hours across web and
fofo: 909 ERROR lines, of which 294 (32%) were ProfitMandiBusinessException --
HTTP 400s where the user is simply told what to fix. Any rule on ERROR rate
fires constantly, and an error tracker would rank 'insufficient balance' as the
top issue.

business WARN, no stack trace, 4xx -- expected, user-correctable
integration ERROR + dependency name -- ours is fine, theirs is not
anything else ERROR + stack trace, 500 -- a bug

New IntegrationException carries getDependency(), so two hundred failures of one
gateway group as one problem rather than two hundred unrelated traces. That
category did not exist: such failures were previously either a bare Exception
(indistinguishable from our own bug) or a business exception (which wrongly
blames the user).

printStackTrace removed from the web handler -- it was writing a second copy of
every trace to catalina.out.

Prerequisite for wiring the GlitchTip appender, which must not be attached until
ERROR means something.

+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/exception/IntegrationException.java
~ /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/GlobalExceptionHandler.java
~ /trunk/profitmandi-web/src/main/java/com/spice/profitmandi/web/controller/GlobalExceptionHandler.java

Rev 22904 –

amit.gupta — Tue, 14 Nov 2017 15:35:28 +0530

amit.gupta – 1 file(s) modified

~ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/exception/ProfitMandiBusinessException.java

Rev 21543 –

ashik.ali — Wed, 24 May 2017 13:29:06 +0530

ashik.ali – 42 file(s) modified

+ /trunk/profitmandi-common/src
+ /trunk/profitmandi-common/src/main
+ /trunk/profitmandi-common/src/main/java
+ /trunk/profitmandi-common/src/main/java/com
+ /trunk/profitmandi-common/src/main/java/com/spice
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/exception
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/exception/ProfitMandiBusinessException.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/model
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/model/BillingDetail.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/model/CustomLineItem.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/model/CustomRole.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/model/CustomTransaction.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/model/ItemQty.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/model/ProfitMandiConstants.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/model/ShipmentUpdate.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/model/ShippedOrder.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/model/ShippedOrderDetail.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/model/ShippingAddress.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/model/ShipppingDetail.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/model/UnshippedOrder.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/model/UserInfo.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/model/UserMessagePojo.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/ResponseCodeHolder.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/services
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/services/AramexTrackingService.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/services/BlueDartTrackingService.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/services/ContentServingService.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/services/MemCache.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/services/SnapdealProductPageParser.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/util
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/util/FormattingUtils.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/util/JWTUtil.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/util/StringUtils.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/util/Utils.java
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/thrift
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/thrift/clients
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/thrift/clients/config
+ /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/thrift/clients/config/ConfigClient.java
+ /trunk/profitmandi-common/src/main/resources
+ /trunk/profitmandi-common/src/main/resources/response-codes.properties