Subversion Repositories SmartDukaan

Last modification

• Rev 37568 – 29 d 9 h
• Author: amit

• Log message:

  offer circular: a failed web-offer sync must not be silent
  
  Swallowing the exception was right - a circular that parsed correctly must stay
  PUBLISHED, and the sync is re-runnable while the parse is the expensive part.
  Swallowing it SILENTLY was not.
  
  A TINYINT(1) cast threw in the sync on every ingest from 2026-09-08 to r37553 and
  nothing looked wrong: processed_at advanced, the circular published, the email said
  success. The only symptom was web_offer.synced_at standing still, which nobody was
  watching. It went unnoticed for two days.
  
  Now:
  - Summary carries webOfferSync, and states it in EVERY case - the counts on success,
  'FAILED - <cause>' on failure, 'NOT RUN' if it never executed. A missing line would
  be indistinguishable from a sync that never ran, so there is no missing line.
  - That lands in offer_document.ingest_summary, so the review screen shows it.
  - The notification email carries it too, and a failure renders as a red
  'Web offers NOT updated' block saying partners are still seeing the previous
  offers and that the parse itself is fine.
  - The sync now runs BEFORE published(), so its outcome is part of what gets recorded
  rather than an afterthought. It is still REQUIRES_NEW with its exception caught, so
  it still cannot fail the ingest.