Subversion Repositories SmartDukaan

Last modification

• Rev 37726 – 19 d 10 h
• Author: amit

• Log message:

  sentry: stop developer laptops reporting to the live GlitchTip board
  
  GlitchTip #586 was 57 events tagged environment=production whose stack read
  /opt/homebrew/Cellar/tomcat@8/8.5.100/libexec/... with server_name set to a
  developer's machine. Nothing was wrong on prod: a laptop was posting into the
  production project and was indistinguishable from it.
  
  Two things combined to allow that. The DSN lives in log4j2.xml, which ships inside
  every build, so any machine running this code can report. And the Sentry SDK
  defaults `environment` to "production" when it is not set -- which it never was --
  so local runs arrived pre-labelled as prod.
  
  Adds sentry.properties to each module, read off the classpath by the SDK itself
  (io.sentry.config.PropertiesProviderFactory) and merged over the appender's config.
  Both keys used here are honoured by io.sentry.ExternalOptions in 7.22.6 (verified
  against the jar): `enabled` and `environment`.
  
  The COMMITTED values are the safe ones -- enabled=false, environment=dev -- so a
  plain local build is silent. build.gradle rewrites both from -Penv= alongside the
  env.property it already writes, so only a deliberate -Penv=staging|prod build
  reports, and it carries the right environment tag. tasks.build.doLast restores the
  safe default afterwards, mirroring the existing handling of env.property.
  
  Verified both directions: default build leaves enabled=false/environment=dev,
  -Penv=prod yields enabled=true/environment=prod.
  
  Note this makes the board trustworthy rather than merely quieter: events can now be
  filtered on environment, and anything unlabelled is a build that predates this.