Subversion Repositories SmartDukaan

Last modification

• Rev 37632 – 2 d 15 h
• Author: aman

• Log message:

  fix(loi): don't leave an LOI half signed when the signed PDF fails to save
  
  Confirm Sign stores the partner OTP (/validateLoiOtp) before the browser builds and uploads the
  signed PDF (/saveLoiDoc). When that second step failed - html2pdf not loaded from cdnjs, upload
  rejected, tab closed, server error - nothing was shown, no LOI mail went out, no onboarding was
  created, and because loiOtpPresent hid Generate LOI the filler could never re-sign (LOI 734).
  
  - pendingFormList: loiOtpPresent only when OTP AND loiDoc are both saved; new loiSignIncomplete
  flag shows a red "signed LOI not saved" note on the Pending LOI list (web + V2 app).
  - loi-form.js Confirm Sign: every failure after the OTP says the LOI was NOT saved and how to
  retry; checks html2pdf is loaded; success alert only after /saveLoiDoc confirms; no double submit.
  - /saveLoiDoc (fofo + V2): refuses a document without a verified OTP; a repeat call for an
  already saved LOI is a no-op (no second mail / completion).
  - /validateLoiOtp (fofo + V2): clear message when no OTP was sent in 24h; reports the real
  rejection reason (e.g. OTP already used) instead of always "wrong".
  - sendSignedLoiPdfToPartner: filler without a manager no longer throws and rolls back the save.
  - OtpProcessor.generateOtp: never hands back an already verified OTP under the 2-minute throttle.
  - AppConfig version 423 for loi-form.js.
  
  Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
  Claude-Session: https://claude.ai/code/session_01RhJD2sc6pf3Zd7f4hyGxhH