Subversion Repositories SmartDukaan

Last modification

• Rev 37486 – 39 d 17 h
• Author: amit

• Log message:

  mail: fix prod outage -- MailOutboxService must not implement MailQueue
  
  r37478 added 'implements MailQueue' to MailOutboxService. That took down both
  ROOT.war and profitmandi-web.war on the 18:19 deploy today; every route 404'd
  because neither Spring context would start.
  
  MailOutboxService has @Transactional methods, so Spring has to proxy it, and
  @EnableTransactionManagement in both WebDBContextConfigure classes runs with the
  default proxyTargetClass=false. While the class implemented no interface Spring
  proxied it with a CGLIB subclass, which is still a MailOutboxService. Adding an
  interface switched it to a JDK proxy implementing only MailQueue, so all 39
  sites that inject the concrete MailOutboxService failed:
  
  BeanNotOfRequiredTypeException: Bean named 'mailOutboxService' is expected to
  be of type MailOutboxService but was actually of type com.sun.proxy.$Proxy1519
  
  The interface moves to a new MailQueueAdapter, which delegates to
  MailOutboxService and carries no transactional annotations. MailQueueHolder and
  EmailServiceImpl inject it by the MailQueue interface, so Utils.sendMail* and
  EmailService still reach the outbox unchanged. MailOutboxService goes back to
  implementing nothing, and its ~112 existing call sites are untouched.
  
  Chose this over proxyTargetClass=true, which would have flipped proxying for
  every interface-implementing service in the app -- too broad for a hot fix.
  
  Verified with javap inside both built WARs: MailOutboxService declares no
  interfaces, MailQueueAdapter implements MailQueue.
  
  Note for cron: it shares the dao jar, so a rebuild picks this up. Do not restart
  cron on trunk without rebuilding it first.