Subversion Repositories SmartDukaan

Rev

Show changed files | Directory listing | RSS feed

Filtering Options

Rev Age Author Path Log message Diff
35721 0 m ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/ code commit for calling target / retailer contact  
35720 9 m ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/ code commit for calling target / retailer contact  
35719 10 h 52 m amit /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/warehouse/ Fix performance issues and email bug in PurchaseOrderServiceImpl

- createPurchaseOrder: batch item loading (selectByIds) and vendor pricing (getVendorPricesOnDate) instead of per-item DB calls; remove duplicate itemIds computation
- grnPoModels: batch load all items upfront instead of selectById per GRN model in nested loop
- generatePdf: fix bug where supplier email recipients were never assigned (Arrays.asList result was discarded)
 
35718 11 h 44 m amit /trunk/PyProj/src/shop2020/ fix: use session.remove() instead of session.close() to prevent memory leaks in all services  
35717 12 h 2 m amit /trunk/ Fix performance issues in PurchaseOrderController

- Replace supplierRepository.selectAll() with targeted selectBySupplierIds() in 2 endpoints
- Replace sellerRepository.selectAll() with new selectByIds() in 2 endpoints
- Add SellerRepository.selectByIds(List<Integer>) batch method
- Remove dead code: unused totalUnitPrice and totalPriceOfLineItem computations
 
35716 12 h 5 m amit /trunk/ Refactor GrnController and PurchaseOrderController: extract business logic into focused services and fix N+1 query performance issues

- Create InvoiceService: invoice item CRUD, validation, vendor price matching
- Create GrnRequestService: GRN request lifecycle, mismatch resolution state machine
- Create DebitNoteService: debit note generation, PDF model building
- Move PO amendment logic from PurchaseOrderController to PurchaseOrderService
- Delegate generateDebitNote from PurchaseOrderServiceImpl to DebitNoteService
- Thin GrnController from ~1215 to ~717 lines, remove 15 unused autowired dependencies
- Thin PurchaseOrderController editPurchaseOrder from 40+ lines to 3 lines

Performance fixes:
- InvoiceServiceImpl.validateInvoiceDetail: batch item/vendor pricing/GST loading (4N+3 queries -> ~5)
- DebitNoteServiceImpl: batch item loading in buildDebitNotePdfModel and generateDebitNote
- GrnController.generateDebitNote: eliminate 2 redundant DB fetches
- Replace 3x supplierRepository.selectAll() with targeted selectBySupplierIds()
 
35715 16 h 6 m ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/smartping/model/ code commit for calling target / retailer contact  
35714 16 h 26 m ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/ code commit for calling target / retailer contact  
35713 16 h 42 m ranu /trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/ code commit for calling target / retailer contact  
35712 16 h 48 m ranu /trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/ code commit for calling target / retailer contact  
35711 16 h 57 m ranu /trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/ code commit for calling target / retailer contact  
35710 17 h 7 m ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/repository/cs/ code commit for calling target / retailer contact  
35709 17 h 16 m ranu /trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/ code commit for calling target / retailer contact  
35708 17 h 20 m ranu /trunk/profitmandi-web/src/main/java/com/spice/profitmandi/web/controller/ now recording also fetching  
35707 17 h 23 m amit /trunk/Crm/src/main/webapp/WEB-INF/content/ fix: make refund amount field editable in return order view  
35706 17 h 31 m ranu /trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/ code commit for calling target / retailer contact  
35705 17 h 40 m amit /trunk/PyProj/src/ Include resource files (cfg, xml, xls) in egg build via package_data  
35704 17 h 46 m amit /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/model/ Fixed SchemeService  
35703 17 h 51 m ranu /trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/ code commit for calling target / retailer contact  
35702 17 h 52 m ranu /trunk/ now recording also fetching  

Show All