| Rev |
Age |
Author |
Path |
Log message |
Diff |
| 35571 |
5 m |
amit |
/trunk/profitmandi-fofo/src/main/ |
Quick wins and medium effort improvements for ticket system
Quick Wins:
- Add input validation to updatePartnerPosition (check positionId, regionId, fofoIds exist)
- Keep SortOrder import (from javax.swing, needed for pagination)
Medium Effort:
- Extract common modal CSS and HTML to shared partials (activity-modal-styles.vm, activity-modal.vm)
- Add null safety checks for maps in getTicket, getMyPartyTicketTicket, getManagerTickets
- Fix N+1 query in getMyPartyTicketTicket: batch fetch tickets using selectAllOpenTickets(fofoIds) instead of loop |
|
| 35570 |
18 m |
amit |
/trunk/ |
Ticket system improvements: Fix N+1 query in getActivity, add input validation in createPosition, optimize getManagerTickets
- DocumentRepository: Add selectByIds for batch fetching documents
- CsController.getActivity: Replace N+1 document fetch with batch query, remove incorrect persist during GET
- CsController.createPosition: Add validation for authUserId, categoryId, regionId, and fofoIds before creating position
- CsController.getManagerTickets: Fix duplicate activity query, fetch only required AuthUsers instead of all users |
|
| 35569 |
49 m |
amit |
/trunk/profitmandi-fofo/src/main/ |
CRM-only external communication + performance & security improvements
Feature:
- Restrict external communication (COMMUNICATION_OUT) to CRM team only (category_id=9)
- Non-CRM users can only send internal communications
- Hide internal/external checkbox for non-CRM users in UI
Performance:
- Eliminate duplicate AuthUser fetch in getTicket() - reuse variable
- Eliminate duplicate activity query (selectAll called twice)
- Fetch only needed AuthUsers instead of all users for activity display
- Same optimizations applied to getMyPartyTicketTicket()
Security:
- Add escapeHtml() function to prevent XSS in activity messages
- Applied to all user-generated content display
UX:
- Add loading spinner while fetching activities
Code Quality:
- Add ActivityType constants for consistent usage
- Add toBool() helper for cleaner boolean checks
- Refactored loadActivities() for better readability |
|
| 35568 |
1 d 9 h |
amit |
/trunk/profitmandi-cron/src/main/java/com/smartdukaan/cron/ |
Refactor ticket scheduled tasks: fix bugs, add test mode, improve performance
Bug fixes:
- Remove break statement in alertforTicket that stopped after first user
- Remove duplicate ticketClosed() method (used 7 calendar days vs 8 working days)
- Update Application.java CLI handler to use refactored escalateTicket()
New features:
- Add email test mode: redirect all emails to tester via config
- ticket.email.testMode.enabled=true/false
- ticket.email.testMode.recipient=tester@email.com
- Add configurable auto-escalation: ticket.autoEscalation.enabled
- Working days calculation using WorkingDaysService (excludes Sun + holidays)
Performance improvements:
- Batch fetch ticketSubCategoryMap once per job, not per email
- All repository calls moved outside loops (N+1 query fix)
Escalation thresholds updated:
- L1 -> L2: 3 working days
- L2 -> L3: 3 working days
- L3 -> Final: 2 working days
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> |
|
| 35567 |
1 d 9 h |
amit |
/trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/ |
Ticket system improvements: working days service and batch queries
- Add WorkingDaysService for centralized working days calculation
- Excludes Sundays and public holidays from database
- Saturdays are counted as working days
- Methods: isWorkingDay, countWorkingDays, addWorkingDays, isDeadlineExceeded
- Add new escalation constants in Ticket.java (L2=3, L3=3, Final=2 working days)
- Add selectByIds batch query to TicketAssignedRepository to eliminate N+1 queries
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> |
|
| 35566 |
2 d 5 h |
ranu |
/trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/ |
recording service updated |
|
| 35565 |
3 d 0 h |
vikas |
/trunk/WarehouseService/ |
Replace defunct onejar-maven-plugin with maven-shade-plugin
The onejar-maven-plugin from Google Code repository is no longer available.
Replaced with maven-shade-plugin 3.2.4 which provides equivalent functionality
for creating executable uber-jars. |
|
| 35564 |
3 d 1 h |
amit |
/trunk/ |
Fix getItemAvailabilityAtLocation method calls - add missing third parameter (stateId)
The method signature requires 3 parameters (itemId, sourceId, stateId) but was being called with only 2.
Added -1 as the third parameter to match other working usages in the codebase. |
|
| 35563 |
3 d 4 h |
ranu |
/trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/repository/cs/ |
tickets updated |
|
| 35562 |
3 d 4 h |
ranu |
/trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/repository/cs/ |
tickets updated |
|
| 35561 |
3 d 4 h |
ranu |
/trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/ |
ui updated of dashboard |
|
| 35560 |
3 d 5 h |
ranu |
/trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/ |
bulletin updated on dashboard and give access category department |
|
| 35559 |
3 d 5 h |
amit |
/trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/scheme/ |
Fixed SchemeService |
|
| 35558 |
3 d 5 h |
aman |
/trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/ |
Feat : Contact Us update |
|
| 35557 |
3 d 5 h |
vikas |
/trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/ |
Hide Oppo Diwali Offer from Dashboard |
|
| 35556 |
3 d 6 h |
ranu |
/trunk/profitmandi-fofo/src/main/webapp/resources/js/ |
bulletin updated on dashboard and give access category department |
|
| 35555 |
3 d 6 h |
ranu |
/trunk/profitmandi-fofo/src/main/webapp/resources/js/ |
bulletin updated on dashboard and give access category department |
|
| 35554 |
3 d 6 h |
ranu |
/trunk/profitmandi-fofo/src/main/ |
bulletin updated on dashboard and give access category department |
|
| 35553 |
3 d 6 h |
ranu |
/trunk/profitmandi-fofo/src/main/ |
bulletin updated on dashboard and give access category department |
|
| 35552 |
3 d 7 h |
ranu |
/trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/ |
bulletin updated on dashboard and give access category department |
|