Subversion Repositories SmartDukaan

Rev

Show changed files | Directory listing | RSS feed

Filtering Options

Rev Age Author Path Log message Diff
37522 11 m ranu /trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/ rbm drr dashboard po fragment ui modification  
37521 50 m ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/model/ rbm drr dashboard position wise data  
37520 51 m ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/model/ rbm drr dashboard position wise data  
37519 52 m ranu /trunk/ rbm drr dashboard position wise data  
37518 7 h 45 m ranu /trunk/profitmandi-cron/src/main/java/com/smartdukaan/cron/scheduled/ notification scheduler  
37517 1 d 0 h ranu /trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/ rbm drr dashboard position wise data  
37516 1 d 0 h ranu /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/ pending loi download access given to raj singh  
37515 1 d 0 h ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/ notification live fix conflict in app config  
37514 1 d 1 h ranu /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/enumuration/ notification live  
37513 1 d 1 h ranu /trunk/ notification live  
37512 1 d 1 h ranu /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/model/ notification live  
37511 1 d 1 h ranu /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/enumuration/ notification live  
37510 1 d 1 h ranu /trunk/profitmandi-cron/src/main/java/com/smartdukaan/cron/ sales target and achievement added cron and flags  
37509 1 d 1 h ranu /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/enumuration/ rbm drr dashboard , all today po rbm view maped  
37508 1 d 1 h ranu /trunk/ notification live new ....api and modification , ui  
37507 1 d 1 h ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/model/ rbm drr dashboard , all today po rbm view maped  
37506 1 d 1 h ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/model/ rbm drr dashboard , all today po rbm view maped  
37505 1 d 1 h ranu /trunk/ rbm drr dashboard , all today po rbm view maped  
37504 1 d 2 h amit /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/transaction/invoicing/ Stop invoice read paths creating directories (AccessDeniedException 500s)

getInvoicePath called Files.createDirectories, and getInvoiceFile called it on every
download. Invoices are generated by the cron app as root, so /SaholicInvoices/<month>
is 755 root-owned; a download served by Tomcat cannot create a retailer subdirectory
and threw AccessDeniedException.

It threw on line 1 of getInvoiceFile, before the Files.exists check, so the
ProfitMandiBusinessException on the next line was unreachable and the callers'
deliberate 404 handler ("Invoice not yet generated, please retry shortly") never ran.
Downloads for a not-yet-generated invoice 500ed instead of 404ing - the exact log
noise that handler was added to remove.

Split the path computation out: resolveInvoicePath is side-effect free and used by
getInvoiceFile; getInvoicePath keeps the mkdir for the two generation callers
(InvoiceService:558, GstProService:952). The legacy relocation branch creates the
target directory only when there is actually a file to move.

No ops change needed - generation as root already works.
 
37503 1 d 3 h ranu /trunk/profitmandi-cron/src/main/java/com/smartdukaan/cron/ sales target and achievement added cron and flags  

Show All