| Rev |
Age |
Author |
Path |
Log message |
Diff |
| 37381 |
1 d 21 h |
amit |
/trunk/profitmandi-web/src/main/java/com/spice/profitmandi/web/ |
Guard empty item IN () and null billing address on the app sale-details paths
Mirrors fofo r37380 on the profitmandi-web side, where the same two defects exist.
V2FofoOrderController (live mobile-app API, not the dormant fofo V2):
- sale details built itemIds from fofoOrderItems and passed them straight to
itemRepository.selectByIds. An insurance-only sale has no fofo_order_item row,
so the list is empty and selectAllByInOrderByDesc throws "List should not be
empty". The sibling sale-search method in this same file was already guarded;
the detail method was not.
- customerBillingAddressObj was put into the response unconditionally, so an
order with customerAddressId 0 (no address is required for a plain POS sale)
returned null and the app had no name or phone to show. Fall back to the
customer's own name and mobile, matching the invoice PDF. Applied at both sites.
CustomerController: same empty-IN exposure in the customer order-history batch
fetch, where a customer whose only order is an insurance sale yields no order
items. Adds the java.util.HashMap import this file needed (it imports java.util
members individually).
Verified profitmandi-web compiles clean with these changes. Note trunk currently
does NOT build: V2FofoPurchaseReturnController:635 still calls the 4-arg
selectByWarehouseIdsAndDateRange that r37377 widened to 5 args (r37378 updated
the fofo caller but not this one). That break is untouched here and needs its
own fix before a web war can be built. |
|
| 36539 |
101 d 1 h |
aman |
/trunk/profitmandi-web/src/main/java/com/spice/profitmandi/web/ |
Fix:Fix customer address update |
|
| 35458 |
245 d 20 h |
amit |
/trunk/ |
Revert @Transactional(readOnly=true) - keep @Transactional only at Controller level
Changes:
- profitmandi-web: Controllers use @Transactional(rollbackFor = Throwable.class) at class level, removed method-level @Transactional(readOnly = true)
- profitmandi-fofo: Controllers use @Transactional(rollbackFor = Throwable.class) at class level, removed method-level @Transactional
- profitmandi-dao: Removed @Transactional from services/repositories
Exceptions (called from interceptors, need own transaction):
- RoleManager: @Transactional(readOnly = true) - called from interceptor for auth
- PartnerTypeChangeServiceImpl.getBestPartner(): @Transactional - called from JWTUtil via interceptor
Fixed javax.transaction.Transactional to org.springframework.transaction.annotation.Transactional
Fixed rollbackOn to rollbackFor for Spring compatibility |
|
| 35435 |
247 d 4 h |
amit |
/trunk/profitmandi-web/src/main/java/com/spice/profitmandi/web/controller/ |
Add @Transactional(readOnly = true) to GET methods in controllers
Added @Transactional(readOnly = true) to all read-only GET methods across 14 controllers:
- RetailerController (10 methods)
- UserController (16 methods)
- WalletController (5 methods)
- CartController (2 methods)
- StoreController (25 methods)
- DealsController (20 methods)
- ShopController (1 method)
- CustomerController (2 methods)
- NotificationController (3 methods)
- SolrSearchController (2 methods)
- InsuranceController (1 method)
- GatewayController (1 method)
- LeadController (13 methods)
- RechargeController (4 methods)
Total: 105 methods updated
All methods verified to only set @Transient fields on entities, ensuring no dirty writes. |
|
| 35415 |
249 d 1 h |
amit |
/trunk/ |
Commit Changes |
|
| 35196 |
312 d 21 h |
aman |
/trunk/ |
Fix:Customer Billing and create order&stock component |
|
| 32692 |
994 d 22 h |
ranu |
/trunk/ |
added duration days on insurance plan |
|
| 32680 |
996 d 21 h |
ranu |
/trunk/profitmandi-web/src/main/java/com/spice/profitmandi/web/controller/ |
revert code ew 180m days |
|
| 32679 |
996 d 21 h |
ranu |
/trunk/profitmandi-web/src/main/java/com/spice/profitmandi/web/controller/ |
set insurance button on mobile app after 180 days of ew |
|
| 32671 |
997 d 21 h |
ranu |
/trunk/ |
resolved expire time |
|
| 31982 |
1200 d 23 h |
amit.gupta |
/trunk/profitmandi-web/src/main/java/com/spice/profitmandi/web/controller/ |
Added exception for Tablet |
|
| 31147 |
1378 d 0 h |
tejbeer |
/trunk/ |
change |
|
| 31051 |
1408 d 3 h |
amit.gupta |
/trunk/ |
Fixed leads logic |
|
| 31050 |
1408 d 4 h |
amit.gupta |
/trunk/profitmandi-web/src/main/java/com/spice/profitmandi/web/controller/ |
Fixed leads logic |
|
| 31049 |
1408 d 4 h |
amit.gupta |
/trunk/profitmandi-web/src/main/java/com/spice/profitmandi/web/controller/ |
Fixed leads logic |
|
| 31048 |
1408 d 4 h |
amit.gupta |
/trunk/profitmandi-web/src/main/java/com/spice/profitmandi/web/controller/ |
Fixed leads logic |
|
| 29738 |
1702 d 18 h |
tejbeer |
/trunk/ |
change |
|
| 29707 |
1706 d 4 h |
tejbeer |
/trunk/ |
billing change |
|