| Rev |
Age |
Author |
Path |
Log message |
Diff |
| 35589 |
77 d 2 h |
amit |
/trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/ |
Fix fofoId validation to allow 0 (All Partners) in createPosition and updatePartnerPosition
- fofoId=0 is a sentinel value meaning 'All Partners'
- Skip validation when fofoIds contains only 0
- Reject mixed lists like [0, 123, 456] to prevent inconsistent data
- Fixes regression introduced in r35570/r35571 |
|
| 35571 |
82 d 1 h |
amit |
/trunk/profitmandi-fofo/src/main/ |
Quick wins and medium effort improvements for ticket system
Quick Wins:
- Add input validation to updatePartnerPosition (check positionId, regionId, fofoIds exist)
- Keep SortOrder import (from javax.swing, needed for pagination)
Medium Effort:
- Extract common modal CSS and HTML to shared partials (activity-modal-styles.vm, activity-modal.vm)
- Add null safety checks for maps in getTicket, getMyPartyTicketTicket, getManagerTickets
- Fix N+1 query in getMyPartyTicketTicket: batch fetch tickets using selectAllOpenTickets(fofoIds) instead of loop |
|
| 35570 |
82 d 1 h |
amit |
/trunk/ |
Ticket system improvements: Fix N+1 query in getActivity, add input validation in createPosition, optimize getManagerTickets
- DocumentRepository: Add selectByIds for batch fetching documents
- CsController.getActivity: Replace N+1 document fetch with batch query, remove incorrect persist during GET
- CsController.createPosition: Add validation for authUserId, categoryId, regionId, and fofoIds before creating position
- CsController.getManagerTickets: Fix duplicate activity query, fetch only required AuthUsers instead of all users |
|
| 35569 |
82 d 2 h |
amit |
/trunk/profitmandi-fofo/src/main/ |
CRM-only external communication + performance & security improvements
Feature:
- Restrict external communication (COMMUNICATION_OUT) to CRM team only (category_id=9)
- Non-CRM users can only send internal communications
- Hide internal/external checkbox for non-CRM users in UI
Performance:
- Eliminate duplicate AuthUser fetch in getTicket() - reuse variable
- Eliminate duplicate activity query (selectAll called twice)
- Fetch only needed AuthUsers instead of all users for activity display
- Same optimizations applied to getMyPartyTicketTicket()
Security:
- Add escapeHtml() function to prevent XSS in activity messages
- Applied to all user-generated content display
UX:
- Add loading spinner while fetching activities
Code Quality:
- Add ActivityType constants for consistent usage
- Add toBool() helper for cleaner boolean checks
- Refactored loadActivities() for better readability |
|
| 35395 |
114 d 21 h |
amit |
/trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/ |
Fixed performance |
|
| 34913 |
225 d 21 h |
ranu |
/trunk/profitmandi-fofo/src/main/ |
show all parties ticket to abm |
|
| 34908 |
226 d 11 h |
ranu |
/trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/ |
abm allowed for csv upload |
|
| 33864 |
547 d 11 h |
ranu |
/trunk/profitmandi-fofo/src/main/ |
created by showed in tickets |
|
| 33778 |
570 d 9 h |
ranu |
/trunk/profitmandi-fofo/src/main/ |
created by showed on manager tickets |
|
| 33244 |
720 d 9 h |
ranu |
/trunk/ |
add signature added profitmandi exception |
|
| 33081 |
760 d 9 h |
ranu |
/trunk/profitmandi-fofo/src/main/ |
ticket category internal and external |
|
| 32865 |
814 d 3 h |
amit.gupta |
/trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/ |
ok |
|
| 32821 |
821 d 3 h |
shampa |
/trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/ |
remove 0 value |
|
| 32812 |
822 d 10 h |
shampa |
/trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/ |
add/remove position |
|
| 32493 |
924 d 9 h |
amit.gupta |
/trunk/ |
Added changes related to auto order creation when internal po is created |
|
| 31854 |
1079 d 10 h |
amit.gupta |
/trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/ |
Fixed messages |
|
| 31830 |
1088 d 2 h |
amit.gupta |
/trunk/ |
Fixed ticket visibility issues |
|
| 31762 |
1107 d 6 h |
tejbeer |
/trunk/ |
ticket and imei wise scheme related changes |
|
| 31238 |
1218 d 9 h |
amit.gupta |
/trunk/profitmandi-fofo/src/main/ |
Removed unwanted files |
|
| 30426 |
1428 d 7 h |
tejbeer |
/trunk/ |
custom retail change |
|