Subversion Repositories SmartDukaan

Rev

Go to most recent revision | Show changed files | Details | Compare with Previous | Blame | RSS feed

Filtering Options

Rev Age Author Path Log message Diff
35570 32 d 5 h amit /trunk/ Ticket system improvements: Fix N+1 query in getActivity, add input validation in createPosition, optimize getManagerTickets

- DocumentRepository: Add selectByIds for batch fetching documents
- CsController.getActivity: Replace N+1 document fetch with batch query, remove incorrect persist during GET
- CsController.createPosition: Add validation for authUserId, categoryId, regionId, and fofoIds before creating position
- CsController.getManagerTickets: Fix duplicate activity query, fetch only required AuthUsers instead of all users		  
35569 32 d 5 h amit /trunk/profitmandi-fofo/src/main/ CRM-only external communication + performance & security improvements

Feature:
- Restrict external communication (COMMUNICATION_OUT) to CRM team only (category_id=9)
- Non-CRM users can only send internal communications
- Hide internal/external checkbox for non-CRM users in UI

Performance:
- Eliminate duplicate AuthUser fetch in getTicket() - reuse variable
- Eliminate duplicate activity query (selectAll called twice)
- Fetch only needed AuthUsers instead of all users for activity display
- Same optimizations applied to getMyPartyTicketTicket()

Security:
- Add escapeHtml() function to prevent XSS in activity messages
- Applied to all user-generated content display

UX:
- Add loading spinner while fetching activities

Code Quality:
- Add ActivityType constants for consistent usage
- Add toBool() helper for cleaner boolean checks
- Refactored loadActivities() for better readability		  
35395 65 d 0 h amit /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/ Fixed performance  
34913 176 d 0 h ranu /trunk/profitmandi-fofo/src/main/ show all parties ticket to abm  
34908 176 d 14 h ranu /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/ abm allowed for csv upload  
33864 497 d 14 h ranu /trunk/profitmandi-fofo/src/main/ created by showed in tickets  
33778 520 d 13 h ranu /trunk/profitmandi-fofo/src/main/ created by showed on manager tickets  
33244 670 d 12 h ranu /trunk/ add signature added profitmandi exception  
33081 710 d 13 h ranu /trunk/profitmandi-fofo/src/main/ ticket category internal and external  
32865 764 d 6 h amit.gupta /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/ ok  
32821 771 d 7 h shampa /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/ remove 0 value  
32812 772 d 13 h shampa /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/ add/remove position  
32493 874 d 13 h amit.gupta /trunk/ Added changes related to auto order creation when internal po is created  
31854 1029 d 13 h amit.gupta /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/ Fixed messages  
31830 1038 d 6 h amit.gupta /trunk/ Fixed ticket visibility issues  
31762 1057 d 10 h tejbeer /trunk/ ticket and imei wise scheme related changes  
31238 1168 d 13 h amit.gupta /trunk/profitmandi-fofo/src/main/ Removed unwanted files  
30426 1378 d 10 h tejbeer /trunk/ custom retail change  
28457 1718 d 9 h tejbeer /trunk/ change  
27690 1855 d 7 h amit.gupta /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/  

←Prev12Next→

Show All