Subversion Repositories SmartDukaan

Rev

Go to most recent revision | Show changed files | Details | Compare with Previous | Blame | RSS feed

Filtering Options

Rev Age Author Path Log message Diff
37632 22 d 12 h aman /trunk/ fix(loi): don't leave an LOI half signed when the signed PDF fails to save

Confirm Sign stores the partner OTP (/validateLoiOtp) before the browser builds and uploads the
signed PDF (/saveLoiDoc). When that second step failed - html2pdf not loaded from cdnjs, upload
rejected, tab closed, server error - nothing was shown, no LOI mail went out, no onboarding was
created, and because loiOtpPresent hid Generate LOI the filler could never re-sign (LOI 734).

- pendingFormList: loiOtpPresent only when OTP AND loiDoc are both saved; new loiSignIncomplete
flag shows a red "signed LOI not saved" note on the Pending LOI list (web + V2 app).
- loi-form.js Confirm Sign: every failure after the OTP says the LOI was NOT saved and how to
retry; checks html2pdf is loaded; success alert only after /saveLoiDoc confirms; no double submit.
- /saveLoiDoc (fofo + V2): refuses a document without a verified OTP; a repeat call for an
already saved LOI is a no-op (no second mail / completion).
- /validateLoiOtp (fofo + V2): clear message when no OTP was sent in 24h; reports the real
rejection reason (e.g. OTP already used) instead of always "wrong".
- sendSignedLoiPdfToPartner: filler without a manager no longer throws and rolls back the save.
- OtpProcessor.generateOtp: never hands back an already verified OTP under the 2-minute throttle.
- AppConfig version 423 for loi-form.js.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RhJD2sc6pf3Zd7f4hyGxhH
 
37194 68 d 9 h aman /trunk/ LOI OTP: report real send outcome instead of always 'OTP Sent Successfully!'

The Send OTP button showed success for any HTTP 200, including the daily-cap
failure where the controller returned 'Something went wrong..'. Ops could not
tell a working send from a broken one, so genuine failures were invisible.

- OTPResponse: add 'sent' flag. result=true did not mean anything was
dispatched - the 2-minute resend throttle returns the previous OTP without
contacting the gateway.
- OtpProcessor: set sent=true only on branches that actually dispatch.
- LoiFormController.sentLoiAcceptanceOtp: return {status, sent, message} with
the processor's real reason, wrap generateOtp in try/catch so a dispatch
exception is logged and reported instead of surfacing as a generic 500, and
log loiId/result/sent/reason.
- loi-form.js: check the payload; distinct green/amber/red states, re-enable
the button on failure instead of leaving it stuck on 'Sending...'.
- common.js: optional error callback on doAjaxRequestHandler /
doPostAjaxRequestHandler (additive; existing callers unchanged).
- AppConfig: static resource version 389 -> 390 for the JS change.
 
36399 163 d 12 h amit /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/ Replace mailSender (SendGrid) with gmailRelaySender - SendGrid API key expired/revoked  
36256 177 d 12 h vikas /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/service/ Update SMS endpoints  
36240 180 d 9 h vikas /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/service/ Added Store Code in Visit Report  
35963 214 d 13 h amit /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/ Migrate mail sending to MailOutboxService (CsService, BidService, OtpProcessor, StoreTimelineTat); add date range query for TransactionApproval  
34053 663 d 16 h aman.kumar /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/service/ SMS Notification error  
34014 677 d 10 h amit.gupta /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/service/ Added telemarketer in Otp  
33867 727 d 14 h tejus.lohani /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/ add some field in loiReport and fix some bug of loi otp and fix some onboarding process bugs  
33617 804 d 7 h tejus.lohani /trunk/ develop document rejection mail , Add automailer when LoiForm complete and go to further process , create LoiForm report , for mail and download ,Payment status mail when payment accesp or reject ,  
33578 813 d 9 h tejus.lohani /trunk/ add BrandFee collecting date in brandFeeCollection,Loi form ,loiFromData class , and fix some bugs(modal size , content size adjustment,etc),  
33577 813 d 15 h tejus.lohani /trunk/ fix Some bugs,Improve some Vm,Show pending LoiForm how fill the form and correct some spelling mistakes  
33568 818 d 7 h tejus.lohani /trunk/ 2 times otp send fix and otp Response message fix  
33510 830 d 5 h tejus.lohani /trunk/ these two file moved to dao(OTPResponse and OTPProcessor).  
31828 1268 d 7 h amit.gupta /trunk/ Added new provider for SMS Service  
28375 1975 d 6 h amit.gupta /trunk/profitmandi-web/src/main/java/com/spice/profitmandi/web/processor/  
28305 1989 d 10 h amit.gupta /trunk/profitmandi-web/src/main/java/com/spice/profitmandi/web/processor/  
28260 1996 d 14 h amit.gupta /trunk/profitmandi-web/src/main/java/com/spice/profitmandi/web/processor/  
28259 1996 d 14 h amit.gupta /trunk/profitmandi-web/src/main/java/com/spice/profitmandi/web/processor/  
28258 1996 d 14 h amit.gupta /trunk/profitmandi-web/src/main/java/com/spice/profitmandi/web/processor/  

Show All