Subversion Repositories SmartDukaan

Rev

Go to most recent revision | Show changed files | Details | Compare with Previous | Blame | RSS feed

Filtering Options

Rev Age Author Path Log message Diff
37477 76 d 19 h amit /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/ mail: one way to send mail, and nothing sends inline

There were three overlapping APIs -- Utils.sendMail* (7 static overloads),
EmailServiceImpl.sendMail* (7 more) and MailOutboxService.queueMail* (20). The
first two built their own MimeMessage, hardcoded From: noreply@smartdukaan.com
in eleven places, and pushed straight down whichever JavaMailSender the caller
passed.

That From is why mail was refused: an authenticated Workspace session may send
only as the account it logged in as, and noreply@ is a different identity in the
same domain. Sending inline also meant a failed send was lost outright and took
the calling job down with it, which is how one expired credential came to mark
ten report jobs FAILED.

New in profitmandi-common:
MailQueue - the single entry point; queue() returns once the mail is
recorded, not once it is sent
MailRequest - one value object replacing the 34 overloads
MailSenderType - GOOGLE (authenticated, From rewritten) or RELAY (IP-authorised)

The interface lives in common while MailOutboxService implements it in dao,
because dao depends on common and not the reverse -- Utils and EmailService
could not otherwise reach the outbox at all.

Utils and EmailService keep their signatures so the ~38 call sites still
compile, but now delegate and ignore the JavaMailSender argument; choosing a
transport was never the caller's business. Both are marked deprecated.
MailQueueHolder bridges the static helpers to the bean and is documented as a
compromise, not a pattern.
 
36623 178 d 22 h amit /trunk/profitmandi-common/ Remove ThriftConfig dependency and Thrift client wrappers

- Removed ThriftConfig from build.gradle dependency
- Deleted entire thrift/clients/ directory (16 RPC client files)
- Removed Thrift-dependent methods from Utils.java (getRechargeDisplayStatus, getOrderStatus, getWarehouseClient, etc.)
- Deleted dead code: HelperServiceUtils.java, OrderObject.java
- Moved to profitmandi-dao: WalletHistoryModel.java, ExcelUtils.java, CustomOrder.java
 
35204 396 d 20 h amit /trunk/ Fixed changes related to downloading file at home page  
35102 410 d 4 h amit /trunk/ Added csvn report  
34568 549 d 18 h vikas.jangra /trunk/ Liquidation/Bidding push notification and Publish Email  
33354 920 d 0 h amit.gupta /trunk/ Enhanced Sidbi Sanctions  
33231 943 d 15 h amit.gupta /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/util/ Fixed Utils removed Thrift dependencies  
33045 987 d 0 h amit.gupta /trunk/ Added sidbi and improvements in credit note  
32955 1007 d 0 h amit.gupta /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/util/ Fixed changes  
32724 1069 d 18 h amit.gupta /trunk/ Added changes related to Loan Interest correction and ReturnOrder  
32199 1222 d 16 h amit.gupta /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/util/ Fixed additional scheme logic  
31903 1291 d 1 h amit.gupta /trunk/ Added changes related to new scheme rollout policy  
31697 1346 d 21 h amit.gupta /trunk/ Fixed sales margin logic  
31177 1456 d 0 h tejbeer /trunk/ change  
30122 1716 d 21 h amit.gupta /trunk/ Fixed issue  
29552 1837 d 17 h amit.gupta /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/util/  
28987 1916 d 1 h amit.gupta /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/util/  
28925 1921 d 19 h amit.gupta /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/util/  
28395 2012 d 17 h amit.gupta /trunk/ Added changes for activation schemes  
27285 2208 d 2 h tejbeer /trunk/ change  

Show All