Subversion Repositories SmartDukaan

Rev

Go to most recent revision | Show changed files | Directory listing | RSS feed

Filtering Options

Rev Age Author Path Log message Diff
37518 39 d 17 h ranu /trunk/profitmandi-cron/src/main/java/com/smartdukaan/cron/scheduled/ notification scheduler  
37517 40 d 10 h ranu /trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/ rbm drr dashboard position wise data  
37516 40 d 10 h ranu /trunk/profitmandi-fofo/src/main/java/com/spice/profitmandi/web/controller/ pending loi download access given to raj singh  
37515 40 d 10 h ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/ notification live fix conflict in app config  
37514 40 d 10 h ranu /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/enumuration/ notification live  
37513 40 d 10 h ranu /trunk/ notification live  
37512 40 d 10 h ranu /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/model/ notification live  
37511 40 d 10 h ranu /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/enumuration/ notification live  
37510 40 d 10 h ranu /trunk/profitmandi-cron/src/main/java/com/smartdukaan/cron/ sales target and achievement added cron and flags  
37509 40 d 10 h ranu /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/enumuration/ rbm drr dashboard , all today po rbm view maped  
37508 40 d 11 h ranu /trunk/ notification live new ....api and modification , ui  
37507 40 d 11 h ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/model/ rbm drr dashboard , all today po rbm view maped  
37506 40 d 11 h ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/model/ rbm drr dashboard , all today po rbm view maped  
37505 40 d 11 h ranu /trunk/ rbm drr dashboard , all today po rbm view maped  
37504 40 d 12 h amit /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/transaction/invoicing/ Stop invoice read paths creating directories (AccessDeniedException 500s)

getInvoicePath called Files.createDirectories, and getInvoiceFile called it on every
download. Invoices are generated by the cron app as root, so /SaholicInvoices/<month>
is 755 root-owned; a download served by Tomcat cannot create a retailer subdirectory
and threw AccessDeniedException.

It threw on line 1 of getInvoiceFile, before the Files.exists check, so the
ProfitMandiBusinessException on the next line was unreachable and the callers'
deliberate 404 handler ("Invoice not yet generated, please retry shortly") never ran.
Downloads for a not-yet-generated invoice 500ed instead of 404ing - the exact log
noise that handler was added to remove.

Split the path computation out: resolveInvoicePath is side-effect free and used by
getInvoiceFile; getInvoicePath keeps the mkdir for the two generation callers
(InvoiceService:558, GstProService:952). The legacy relocation branch creates the
target directory only when there is actually a file to move.

No ops change needed - generation as root already works.
 
37503 40 d 13 h ranu /trunk/profitmandi-cron/src/main/java/com/smartdukaan/cron/ sales target and achievement added cron and flags  
37502 40 d 13 h ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/icicilombard/model/ sales target and achievement added cron and flags  
37501 40 d 13 h ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/icicilombard/model/ sales target and achievement added cron and flags  
37500 40 d 13 h ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/ sales target and achievement added cron and flags  
37499 40 d 13 h ranu /trunk/ sales target and achievement added cron and flags  

Show All