Subversion Repositories SmartDukaan

Rev

Go to most recent revision | Show changed files | Details | Compare with Previous | Blame | RSS feed

Filtering Options

Rev Age Author Path Log message Diff
35571 186 d 0 h amit /trunk/profitmandi-fofo/src/main/ Quick wins and medium effort improvements for ticket system

Quick Wins:
- Add input validation to updatePartnerPosition (check positionId, regionId, fofoIds exist)
- Keep SortOrder import (from javax.swing, needed for pagination)

Medium Effort:
- Extract common modal CSS and HTML to shared partials (activity-modal-styles.vm, activity-modal.vm)
- Add null safety checks for maps in getTicket, getMyPartyTicketTicket, getManagerTickets
- Fix N+1 query in getMyPartyTicketTicket: batch fetch tickets using selectAllOpenTickets(fofoIds) instead of loop		  
35569 186 d 0 h amit /trunk/profitmandi-fofo/src/main/ CRM-only external communication + performance & security improvements

Feature:
- Restrict external communication (COMMUNICATION_OUT) to CRM team only (category_id=9)
- Non-CRM users can only send internal communications
- Hide internal/external checkbox for non-CRM users in UI

Performance:
- Eliminate duplicate AuthUser fetch in getTicket() - reuse variable
- Eliminate duplicate activity query (selectAll called twice)
- Fetch only needed AuthUsers instead of all users for activity display
- Same optimizations applied to getMyPartyTicketTicket()

Security:
- Add escapeHtml() function to prevent XSS in activity messages
- Applied to all user-generated content display

UX:
- Add loading spinner while fetching activities

Code Quality:
- Add ActivityType constants for consistent usage
- Add toBool() helper for cleaner boolean checks
- Refactored loadActivities() for better readability		  
33864 651 d 10 h ranu /trunk/profitmandi-fofo/src/main/ created by showed in tickets  
31762 1211 d 5 h tejbeer /trunk/ ticket and imei wise scheme related changes  
27285 2092 d 11 h tejbeer /trunk/ change  
27270 2094 d 3 h tejbeer /trunk/ change  
26318 2358 d 4 h tejbeer /trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/ change  
24824 2670 d 10 h govind /trunk/ Internal Communication  
24791 2676 d 5 h govind /trunk/  
24787 2677 d 4 h govind /trunk/  
24699 2688 d 7 h govind /trunk/  
24685 2691 d 4 h govind /trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/  
24638 2697 d 9 h govind /trunk/profitmandi-fofo/src/main/  
24620 2701 d 4 h govind /trunk/ closing ticket  
24569 2705 d 8 h govind /trunk/ Issues resolved in ticket  
24534 2710 d 8 h govind /trunk/profitmandi-fofo/src/main/webapp/ Modification in Ticket not showing assignee  
24530 2711 d 11 h amit.gupta /trunk/profitmandi-fofo/src/main/webapp/WEB-INF/views/ftl/ 1. Fixed styling issues in dialogs
2. Added count to the IMEIS		  
24500 2722 d 5 h govind /trunk/ Ticket Changes  
24469 2730 d 4 h govind /trunk/profitmandi-fofo/src/main/webapp/  
24439 2737 d 3 h govind /trunk/  

←Prev12Next→

Show All