Subversion Repositories SmartDukaan

Rev

Show changed files | Directory listing | RSS feed

Filtering Options

Rev Age Author Path Log message Diff
37749 14 d 19 h vikas /trunk/ Upload directory and Data correction for lead  
37731 17 d 1 h amit /trunk/profitmandi-dao/src/main/ Remove dead third-party integrations: dao

Nothing removed here had a live caller. No tables are touched.

- Toffee Insurance client + models, and the tofee.* keys in shared-*.properties
- Bharti Assist (BAG) service and its certificate/brand models. BagPlanModel
and PlanVariant stay in bharti/model: OneAssist and ICICI Lombard use them.
- Private, uncalled Toffee/BAG request builders in InsuranceServiceImpl
- Wiseapp insurance client and ZestResponseModel
- SmartPing client. CallDetailModel and PushCallLogModel move to
kommuno/model because the Knowlarity webhooks still parse them.
- SpiceMoney SSO (2-partner pilot), Thriwe stub + DTOs, DTDC/Shipsy (demo
URLs only), Blue Dart SOAP stubs, legacy Pine Labs v1 client
- FundFina pre-approval entity/repository, HyperTrack key entity/repository,
affiliate Click entity/repository
- Speqtra SMS constant; aramex.tracking.url keys
- PAYU PAY entry in payment-options.json

Gateway.MANDII and Gateway.FUNDFINA stay: historical fofo.payment rows.
 
37656 21 d 20 h amit /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/ Point dao at the relocated KYC and SD Credit types (r37655)

Imports follow services.mandii -> services.kyc / services.sdcredit, and
RecordingService takes RawHttpResponse in place of MandiiResponse.

Gateway.MANDII is kept, with a comment saying why: it is persisted as a
string on FofoPayment.gateway and CreditAccount.gateway, and 740 historical
fofo.payment rows still carry it - removing the constant would make
Hibernate throw when reading them.
 
37552 29 d 0 h amit /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/ lead/knowlarity: stop a null lookup key from matching every row

selectByEquals maps a null VALUE to NO PREDICATE AT ALL rather than to "= null",
because GenericRepositoryImpl.prepareEqualPredicate skips null entries. So a null
lookup key does not miss -- it selects the whole table and dies on
NonUniqueResultException. Two live call paths were doing exactly that.

RecordingService.updateAgentCallLog read caller_id, which knowlarity has never sent
on push-call-log: a sample of 50 live webhooks contained it zero times. Every call
therefore ran selectByCallerId(null) -> "select every sip_master row" -> throw, and
the whole feed was discarded. 17 of those 50 were Connected calls with a real agent.
Resolve the agent from agent_number instead, which is the field that actually
identifies them and holds the sip_url; it arrives bare, sip:-prefixed, or as the
literals "False"/"None" when nobody picked up. caller_id is still honoured first in
case they ever start sending it. A payload naming no agent is INFO, and an agent
missing from sip_master is WARN (an ops fix, and per-agent, so an ERROR would
fingerprint into one GlitchTip issue per agent).

AuthRepositoryImpl.putEmailOrMobile had the same hole via Long.parseLong(null)
falling into the catch and putting a null email. selectByEmailOrMobile(null)
degenerated to "select all 405 users", and authenticate(null, hash) degenerated to
"does ANY user have this password hash", which would answer true. Both fail closed
today only as an accident of how many rows the table holds, so the guard goes on the
one path they share.

Fixes GlitchTip #58/#1324/#1335 (fofo, 281 events) and #10 (web).
 
36200 184 d 18 h ranu /trunk/ error correctly will show  
35757 237 d 18 h ranu /trunk/ rbm calls date wise filter given  
35725 239 d 22 h ranu /trunk/ now recording also fetching  
35724 240 d 0 h ranu /trunk/ now recording also fetching  
35702 240 d 19 h ranu /trunk/ now recording also fetching  
35692 241 d 1 h ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/kommuno/ code commit for calling target / retailer contact  
35691 241 d 1 h ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/kommuno/ code commit for calling target / retailer contact  
35688 242 d 13 h ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/kommuno/ web deploye for active category  
35687 242 d 13 h ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/kommuno/ code commit for calling target / retailer contact  
35685 242 d 18 h ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/kommuno/ code commit for calling target / retailer contact  
35684 242 d 19 h ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/service/integrations/kommuno/ code commit for calling target / retailer contact  
35681 242 d 19 h ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/ code commit for calling target / retailer contact  
35679 242 d 19 h ranu /trunk/ calling webhook updated  
35658 246 d 0 h ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/ call target related changes  
35566 264 d 21 h ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/ recording service updated  
34793 450 d 20 h ranu /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/ code committed for sip  

Show All