Subversion Repositories SmartDukaan

Rev

Show changed files | Directory listing | RSS feed

Filtering Options

Rev Age Author Path Log message Diff
37730 16 d 1 h amit /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/ Remove dead third-party integrations: common

Part of the integrations cleanup across all modules. Nothing here had a
live caller.

- Snapdeal product-page parser and UserMessagePojo (affiliate live pricing)
- FundFina request/response DTOs (inbound lender API, removed)
- Aramex XML tracking client (only reachable via /track provider=2)
- WiseApp insurance model
- URL constants for PayU, the SmartPing caller-ID hook, affiliate clicks and
live pricing; the SmartPing agent map
 
37655 20 d 20 h amit /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/ Remove the dead Mandii BNPL integration (common)

Mandii has taken no payment since 2022-08-23 and holds no credit account, so
MandiiService and the 29 classes only it used are deleted.

The package had become a home for live types, which are moved out rather than
lost: Gender/MaritalStatus/AddressProofType -> services.kyc (they back
@Enumerated columns on user.fofo_kyc, 317 rows), and the SD Credit account
status model - AccountStatusResponseOut and its 10 dependencies ->
services.sdcredit, still served by GatewayController for SDDIRECT.

MandiiResponse was a generic body+status holder named after the integration;
renamed RawHttpResponse, still used by RestClient for Kommuno recordings.
Its dead getMandii() helper is gone. AccountStatusResponseOut no longer
carries the hardcoded merchant.mandii.com URL it shipped to the app.

FundfinaService was logging under MandiiService.class - fixed.
 
37627 22 d 0 h amit /trunk/profitmandi-common/src/ feat(mail): drop inactive recipients before send

Add MailRecipientFilter and RecipientFilteringMailSender, which strips To/Cc/Bcc addresses the filter reports inactive and skips a mail left with no recipients instead of failing. AuthenticatedIdentityMailSender now extends it.
 
37477 36 d 20 h amit /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/ mail: one way to send mail, and nothing sends inline

There were three overlapping APIs -- Utils.sendMail* (7 static overloads),
EmailServiceImpl.sendMail* (7 more) and MailOutboxService.queueMail* (20). The
first two built their own MimeMessage, hardcoded From: noreply@smartdukaan.com
in eleven places, and pushed straight down whichever JavaMailSender the caller
passed.

That From is why mail was refused: an authenticated Workspace session may send
only as the account it logged in as, and noreply@ is a different identity in the
same domain. Sending inline also meant a failed send was lost outright and took
the calling job down with it, which is how one expired credential came to mark
ten report jobs FAILED.

New in profitmandi-common:
MailQueue - the single entry point; queue() returns once the mail is
recorded, not once it is sent
MailRequest - one value object replacing the 34 overloads
MailSenderType - GOOGLE (authenticated, From rewritten) or RELAY (IP-authorised)

The interface lives in common while MailOutboxService implements it in dao,
because dao depends on common and not the reverse -- Utils and EmailService
could not otherwise reach the outbox at all.

Utils and EmailService keep their signatures so the ~38 call sites still
compile, but now delegate and ignore the JavaMailSender argument; choosing a
transport was never the caller's business. Both are marked deprecated.
MailQueueHolder bridges the static helpers to the bean and is documented as a
compromise, not a pattern.
 
37451 39 d 6 h amit /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/services/ Send authenticated mail as the account that actually authenticates

googleMailSender logs in to smtp.gmail.com as sdtech@smartdukaan.com, but callers
build their From as noreply@smartdukaan.com. Google Workspace binds an authenticated
session to one identity and refuses the mismatch with 535 'Authorization failed:
Authenticated user is not authorized to send mail' - the password is accepted, the
message is not. Every alert routed through that sender was therefore lost at the SMTP
layer, the e-invoice failure alert for NSUPHR1770 among them.

AuthenticatedIdentityMailSender rewrites From to the sender's own username at send
time, keeping whatever display name the caller chose. Senders that do not authenticate
are left alone: gmailRelaySender is the IP-authorised relay and has no username, and
sendGridMailSender's username is the literal 'apikey', so both keep noreply@.

Enforced in the sender rather than at the ~40 call sites that build their own
MimeMessage and hardcode noreply@, so it covers the ones added next too.
 
36623 138 d 23 h amit /trunk/profitmandi-common/ Remove ThriftConfig dependency and Thrift client wrappers

- Removed ThriftConfig from build.gradle dependency
- Deleted entire thrift/clients/ directory (16 RPC client files)
- Removed Thrift-dependent methods from Utils.java (getRechargeDisplayStatus, getOrderStatus, getWarehouseClient, etc.)
- Deleted dead code: HelperServiceUtils.java, OrderObject.java
- Moved to profitmandi-dao: WalletHistoryModel.java, ExcelUtils.java, CustomOrder.java
 
36555 144 d 7 h amit /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/services/mandii/ Fixed scroll in offers modal  
36398 162 d 23 h amit /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/services/ Replace mailSender (SendGrid) with gmailRelaySender across all modules - SendGrid API key expired/revoked  
36069 195 d 0 h amit /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/ Add premium CD day constants and API fields for partner-type-aware free credit days (Gold/Diamond/Platinum: 10/20, others: 7/15)  
35995 207 d 18 h aman /trunk/ Fix:Redesign the Po Approval page, and po creation logic for first po, trail mails formatting fix  
35917 218 d 22 h amit /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/services/mandii/ Add partnerType field to AccountStatusResponseOut for partner app credit status  
35913 219 d 1 h amit /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/services/mandii/ Add overdueRateOfInterest, freeDays, creditTerms to AccountStatusResponseOut for dynamic TnC  
35641 247 d 2 h aman /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/services/ Fix: Aadhar Front and back uploader and email service  
35623 250 d 0 h amit /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/ Switch Reportico service calls from GET to POST to send params as form body  
35236 344 d 19 h amit /trunk/ Fixed notification related issues with scheme also stopped using mongo for brands Schema  
34692 470 d 19 h vikas.jangra /trunk/ Location Tracking for Admin App  
33798 742 d 0 h ranu /trunk/ penal rate of interest added  
33733 761 d 21 h amit.gupta /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/services/ changed password  
33107 935 d 15 h amit.gupta /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/services/ Fixed password  
33106 935 d 16 h amit.gupta /trunk/profitmandi-common/src/main/java/com/spice/profitmandi/common/services/ Fixed invoices  

Show All