Subversion Repositories SmartDukaan

Last modification

• Rev 37702 2026-09-18 04:06:59
• Author: amit

• Log message:

  Internal movement: an unapproved PO no longer dispatches stock
  
  A PO raised on one of our own warehouses also raises the order that moves the stock, and that
  order pays and processes immediately - so raising it ships goods. The approval gate never
  governed that half. It set the PO to INIT and mailed an approval link, then created and processed
  the order anyway, several lines later and without consulting the status it had just set. The gate
  held back receiving - PO list, GRN matching, auto-close all skip INIT - while dispatch went ahead
  unconditionally.
  
  That is how PO/07-26/52029 was delivered and invoiced while frozen out of GRN. Its goods had to be
  received against a second PO raised for the purpose, leaving the first holding a phantom
  unfulfilled quantity for two months.
  
  Order creation now waits on approval. WarehousePurchaseOrder.isApproved() names the rule once -
  INIT is the only state before approval, every other state is something the order has already been
  approved to do - matching how the PO list, GRN matching and the auto-close sweep already read it,
  so callers stop restating it.
  
  Backdated POs are approved at creation since r37682, so this holds nothing up today; it is what
  keeps the two halves from separating again if any future rule leaves a PO unapproved. Nothing
  raises the order later, so such a PO simply does not move stock and has to be raised again once
  approved - the safe failure, and it is logged.