Subversion Repositories SmartDukaan

Last modification

• Rev 37337 2026-08-18 13:37:58
• Author: amit

• Log message:

  Move offer-circular ingest out of cron and into the portal
  
  The parse now runs in profitmandi-fofo, on a background thread, triggered by the
  upload that produced the document.
  
  Why: splitting one feature across two artifacts with independent deploy cadences
  cost a full day. fofo shipped, cron did not, and a valid upload sat in DRAFT with
  nothing on the server able to parse it - the deployed cron jar contained none of the
  ingest classes. One 9-page PDF a month never justified a batch tier, and the portal
  already ships two PDF stacks, so the isolation argument for keeping PDFBox out was
  weaker than it looked.
  
  - 13 parser classes move verbatim from com.smartdukaan.cron.offercircular to
  com.spice.profitmandi.web.offercircular. No logic changed.
  - CircularIngestScheduler becomes CircularIngestRunner: the @Scheduled(every 5 min)
  entry point and the offer.circular.ingest.enabled flag are gone, replaced by a
  single-threaded daemon executor. All claim, ingest and notification logic is
  unchanged.
  - Upload hands the document id to the runner AFTER COMMIT, not inline. The DRAFT row
  is written inside the request transaction; a worker starting immediately would race
  that commit, find nothing to claim and silently do nothing - which is precisely the
  stuck-on-DRAFT symptom this change removes.
  - The guarded claim is KEPT even though there is now one trigger. It still stops a
  double-submit, a second portal node, and a re-ingest racing an in-flight parse.
  - Re-ingest parses immediately instead of queueing for a scheduler.
  - The stall reaper runs when the review screen loads. There is no timer here any
  more, and a document stranded by a redeploy mid-parse only matters when somebody
  looks for it - which matters more now the parse lives in the web application.
  - tabula moves to this module with its exclusions intact, as does the
  dumpCircularClasspath helper the local ingest harness depends on.
  - Screen no longer claims "the ingest job runs every 5 minutes", which was untrue the
  moment cron stopped being the route; poll interval 15s -> 3s to match a parse that
  takes seconds. jsVersion 404 -> 405.
  - offer.circular.review.url added here, since the runner sends that email now.
  
  Verified: full ingest of the Aug'26 circular through the relocated code is identical
  to the reference - 239 offers, 663 products, 279 AUTO_EXACT, 361 benefits, 511
  tenures, 911 bank links. ProductNamesTest 11/11 in its new home.