Subversion Repositories SmartDukaan

Last modification

• Rev 37380 2026-08-21 18:44:11
• Author: amit

• Log message:

  Fix /saleDetails 500 on insurance-only orders and null billing name/phone
  
  Two defects on the sale-details screen, both from a legitimately-empty source.
  
  1. /saleDetails 500s on an insurance-only order. A policy is not a catalog item,
  so an insurance sale carries no fofo_order_item row; itemIds comes out empty and
  itemRepository.selectByIds hits GenericRepositoryImpl.selectAllByInOrderByDesc,
  which throws "List should not be empty" to guard against an empty IN (). The
  same guard already exists two methods below at the sale-search site, so this
  carries it across to the detail site. 346 orders across 95 partners are affected
  - every insurance-only order ever written. The screen already loads the policies
  and the view renders them, so nothing else was needed to display the sale.
  
  2. Billing name and phone rendered as the literal
  .getName(). A plain POS sale does not require an
  address (only insurance does), so ~140k orders across 1038 partners carry
  customerAddressId 0 and the lookup returns null. The existing guard covered the
  address *string* but the object was added to the model unconditionally, and
  Velocity prints an unresolvable reference verbatim. Fall back to the customer's
  own name and mobile, which the invoice PDF already does via
  OrderServiceImpl.createCustomAddressWithoutId - so screen and invoice now agree.
  The fallback is transient and never persisted; a missing customer row is
  swallowed deliberately, since this feeds a display field and throwing would turn
  blank text into a 500.
  
  Applied at both model-writing sites in this controller.