Subversion Repositories SmartDukaan

Last modification

• Rev 37322 2026-08-17 15:45:41
• Author: amit

• Log message:

  Stop treating IRN transport timeouts as terminal; isolate NIC calls from batch transaction
  
  A read timeout to GSTPro/NIC was recorded as a final verdict (irn_generated=false),
  so 79 invoices billed on 2026-08-17 were left permanently without an IRN even though
  NIC may well have filed them. A timeout means the call never completed, not that the
  document was rejected.
  
  - markEInvoiceFailed -> recordIrnFailure(invoiceNumber, Throwable): transport failures
  leave irn_generated NULL so the cron retries (DUPIRN recovers anything NIC did file);
  only a genuine rejection is terminal. Alert email now fires only when terminal.
  - New einvoice_details.irn_attempt_count bounds that retry at 10 attempts, reset on
  success, so a prolonged NIC outage still converges instead of looping forever.
  Requires the matching ALTER TABLE before deploy.
  - New saveInvoiceInNewTransaction(invoiceNumber): REQUIRES_NEW per invoice, reloading
  orders inside it. RunOnceTasks has class-level @Transactional wrapping the whole
  batch loop, so every NIC call previously ran inside one transaction holding write
  locks on all orders in the batch; at 60s per call that window is unacceptable.
  updateIrnsToInvoices and regenerateBilledInvoices now carry only invoice numbers,
  keeping the batch transaction read-only.
  - Route all NIC calls (IRN gen, auth, cancel, EWB) through the 60s regulator profile
  via GstProAuthService.nicRestClient(). getGstDetails stays on the 10s default since
  it runs on request threads.