Subversion Repositories SmartDukaan

Last modification

• Rev 37481 2026-08-31 17:59:05
• Author: amit

• Log message:

  imei activation: one 2-day billing floor for every brand, and drop two dead methods
  
  The pending pool is a UNION of two channels, not an intersection: an imei qualifies
  if WE billed it to the partner (selectImeiActivationByBrand) or the PARTNER billed it
  on to the end customer (selectImeiActivationByBrandTertiary). The two are disjoint by
  construction -- the secondary query excludes anything carrying a FofoLineItem -- so a
  unit moves from one to the other as it sells through and is never asked about twice.
  Said so on the interface, since the pairing was only documented at the call sites.
  
  billedBefore moves from now-1d to now-2d, so both channels ask only about stock billed
  MORE THAN 2 DAYS ago. Anything sold in the last 48 hours has essentially never been
  activated yet, so the lookup is spent for nothing; it is not lost, the same imei comes
  back into the pool as soon as it crosses the floor, and again every day after that
  until it activates. Kept in the repository rather than per caller so vivo, oppo, realme,
  motorola and the new carlcare pass inherit one rule instead of drifting apart.
  
  Costs almost nothing today -- secondary pool, old floor vs new:
  
  itel 1550 -> 1550 realme 849 -> 849 oppo 2021 -> 2019
  vivo 5018 -> 5016 motorola 1168 -> 1153 tecno 502 -> 495
  
  26 rows across six brands, each deferred by one day.
  
  Removed as dead:
  
  selectImeiActivationPendingByRealme -- a verbatim duplicate of
  selectImeiActivationPendingByBrand down to the named query and the parameters. Nothing
  called it; StandAlone already used the brand-generic method for realme and said so in
  a comment, which is now updated.
  
  selectImeiSoldNotActivatedByBrand -- interface, impl and named query. No callers
  anywhere in web, fofo, cron or dao.