Subversion Repositories SmartDukaan

Last modification

• Rev 37379 2026-08-21 15:27:23
• Author: amit

• Log message:

  Restore insurance lines on invoice PDFs dropped by the r37066 renderer refactor
  
  The modular doc-generation extraction moved the item table into ItemsTableSection,
  which iterates only DocumentData.items() -> model.getOrderItems(). The legacy
  renderer also emitted a row per CustomInsurancePolicy (PdfUtils r36674, lines
  241-261); that block was lost in the extraction and nothing consumed
  getInsurancePolicies() any more.
  
  Effect: an extended-warranty policy is not a catalog item, so it has no
  fofo_order_item row. Insurance sold after the device sale gets its own invoice
  whose only line is the policy, so the whole table came out empty and the totals
  - which SummarySection derives from the table, not from FofoOrder.totalAmount -
  printed as 0.00 / 'Zero Rupees Only' (e.g. HRJND1424/94). On a combined
  device+insurance invoice the policy line vanished silently and the invoice total
  and GST were understated by the premium. InsuranceController's insurer document
  pack, whose model carries policies and no order items at all, hit an NPE.
  
  Fold the policies in at DocumentData.items(), the single accessor every section
  reads, so the fix covers all callers at once. Column mapping mirrors the legacy
  renderer: quantity 1, no discount, taxable value repeated in the Rate column.
  Only the applicable tax side is populated (CGST/SGST or IGST) rather than both
  as the policy model carries them, matching how real order items are built, so
  ItemsTableSection's taxAmount = cgst+sgst+igst stays correct on margin-scheme
  invoices. With no policies the model's own list is returned untouched.
  
  Tests: InsuranceInvoiceRenderTest asserts on extracted PDF text (insurance-only,
  intra/inter-state GST split, combined invoice, and a no-insurance control), so it
  holds on any machine unlike the pixel goldens; three golden baselines added.
  Verified all 14 pre-existing golden fixtures render byte-identical before and
  after.
  
  Also set java.awt.headless=true on the test JVM: the golden harness rasterizes
  through PDFBox, whose font handling calls
  GraphicsEnvironment.getLocalGraphicsEnvironment() and made the forked JVM attach
  to the macOS window server as a Foreground app, stealing focus on every run.
  Test-only property, no effect on the built war.