Subversion Repositories SmartDukaan

Last modification

• Rev 37347 2026-08-18 16:58:26
• Author: amit

• Log message:

  Give the ingest runner a transaction; it had none on its background thread
  
  Parsing failed instantly on production with
  
  org.hibernate.HibernateException: Could not obtain transaction-synchronized
  Session for current thread
  at CircularIngestRepositoryImpl.claimForProcessing
  at CircularIngestRunner.processOne
  
  The runner works on a background thread. Nothing binds a Hibernate session to it, so
  the very first repository call - the claim - threw. Worse, the failure handler called
  markFailed, which threw for the same reason, so nothing was recorded: the document sat
  in DRAFT with no error, no processed_at and no outward sign that anything had gone
  wrong. CircularIngestService.ingest was never reached.
  
  This was latent in the cron version too. It never surfaced because that scheduler was
  never actually deployed anywhere.
  
  - New CircularIngestBookkeeping: claim / document / published / failed /
  reclaimStalled, each REQUIRES_NEW. Independent transactions matter most for failed(),
  which runs after the ingest transaction has already rolled back and must not be
  dragged into it.
  - It is a SEPARATE bean on purpose. @Transactional on the runner's own methods would be
  invoked from inside its own Runnable - a self-invocation never passes through the
  Spring proxy, so the annotation would be silently ignored and the bug would come back
  wearing a disguise.
  - The runner no longer touches CircularIngestRepository at all.
  
  Not caught locally because the RunIngest harness uses JdbcIngestRepo, a plain-JDBC
  implementation that bypasses Hibernate entirely - so it can reproduce the parsing but
  never a session or transaction problem.