Subversion Repositories SmartDukaan

Last modification

• Rev 37332 2026-08-18 11:18:51
• Author: amit

• Log message:

  Move the offer-circular upload directory off a developer home path
  
  Every upload in production failed with a 400 on mkdirs. offer.circular.dir was
  never set in any environment, so it fell back to the code default
  /users/amit/uploads/offer-circulars; Tomcat runs as the tomcat user, which cannot
  create /users at the filesystem root, and the controller threw "Circular storage
  directory is not writable".
  
  - default is now /var/lib/smartdukaan/offer-circulars, a real server path
  - offer.circular.dir set explicitly in prod.properties, and pointed at the
  developer's own space in dev.properties, since /var/lib needs sudo on a
  workstation
  - staging.properties deliberately untouched; the new default covers it
  
  The location has two hard constraints, now recorded on the field itself:
  
  - OUTSIDE webapps/. A redeploy wipes anything under it, and
  offer_document.stored_path is how both re-ingest and re-download resolve the
  PDF, so a wipe breaks them permanently. Stray PDFs are already sitting in
  WEB-INF/classes/META-INF on the server from exactly this mistake.
  - OUTSIDE any web root. A circular carries the OEM's confidential cashback
  economics and must never be servable as a static file. Hence /var/lib rather
  than /var/www, whose local precedent /var/www/partner_stats is chmod 777.
  
  Only fofo needs the key: the cron ingest resolves the PDF from
  offer_document.stored_path and reads it as root, so 0750 tomcat:tomcat is enough.
  
  Deploying this alone does not fix production - the directory must also exist and
  be writable by tomcat.