Subversion Repositories SmartDukaan

Last modification

• Rev 37378 2026-08-21 14:30:59
• Author: amit

• Log message:

  Put the action-pending returns at the top of Sale Returns, and filter by partner
  
  Sorting the received list pending-first changed nothing on screen, because every return
  that still needs an action was missing from it. The list was built from purchase return
  orders inside the date window, and a return order only exists once the warehouse has
  received the goods - so a debit note awaiting receipt had no row to sort, and a return
  sitting unrefunded for weeks fell out of the window entirely.
  
  The screen is now two lists:
  
  - Action Pending, on top, with no date bound. It merges the three shapes a pending return
  takes - a debit note never received, a return order received but unrefunded, and one
  rejected but not yet acknowledged - into a single row type, oldest first, with the age
  in days beside it. Each row carries only the action that actually applies to it
  - Settled Returns below, refunded and cancelled only, still bound to From/To. The pending
  rows were lifted out of it, so nothing is listed twice
  
  Two things worth recording:
  
  - a debit note has no warehouse of its own. It is placed through the item's invoice and
  the order that invoice was raised on, and a note that cannot be placed is dropped rather
  than shown to a warehouse it may not belong to
  - debit notes raised before the receive/refund flow existed were settled the old way and
  cannot be worked from this screen. The cutoff is read from the earliest return order in
  the database, so it needs no maintenance, and the page says so in a footnote instead of
  quietly hiding them
  
  The partner filter reuses the shared /partners typeahead and passes the id down into both
  queries. Only a picked suggestion filters, so a half-typed name cannot blank the page. Its
  handlers sit inline in the template, next to the markup they drive, following the pattern
  add-wallet-request.vm already uses - which leaves the now-unused #invoice-return-date-apply
  handler in return.js dead, to be removed with the return.js work already in flight.
  
  Rendered offline through Velocity with the app's own directive.set.null.allowed to confirm
  all four action variants emit the right buttons.