Subversion Repositories SmartDukaan

Last modification

• Rev 36331 2026-04-21 16:34:45
• Author: amit

• Log message:

  Fix @Cacheable name collision between getSaholicStockList variants
  
  SaholicInventoryServiceImpl:271 and :282 both used @Cacheable(value =
  'saholicCISList') on no-arg methods. Spring's default SimpleKey.EMPTY means
  both methods shared ONE cache entry — whichever was called first poisoned the
  cache for the other, even though they return different filtered sets:
  
  - getSaholicStockList (:272) runs selectWarehouseCisNew — tl.active=1 only
  - getSaholicStockListWithoutCatalogMovingStatus (:283) runs
  selectWarehouseCisNewWithoutCatalogMovingStatus — includes catalog moving
  status join and filters out non-stocked OTHER/SLOWMOVING items
  
  Renamed the second cache to 'saholicCISListWithStatus' so each method uses
  its own namespace. Consumers of either method now get their method's actual
  result, not a random earlier caller's.
  
  This is a correctness fix (wrong cached data) more than a perf fix, though
  it does mean both caches fill independently now (tiny cold-path DB uptick,
  already mitigated by 5-min TTL via timeoutCacheManager).