Subversion Repositories SmartDukaan

Last modification

• Rev 37381 2026-08-21 18:44:23
• Author: amit

• Log message:

  Guard empty item IN () and null billing address on the app sale-details paths
  
  Mirrors fofo r37380 on the profitmandi-web side, where the same two defects exist.
  
  V2FofoOrderController (live mobile-app API, not the dormant fofo V2):
  - sale details built itemIds from fofoOrderItems and passed them straight to
  itemRepository.selectByIds. An insurance-only sale has no fofo_order_item row,
  so the list is empty and selectAllByInOrderByDesc throws "List should not be
  empty". The sibling sale-search method in this same file was already guarded;
  the detail method was not.
  - customerBillingAddressObj was put into the response unconditionally, so an
  order with customerAddressId 0 (no address is required for a plain POS sale)
  returned null and the app had no name or phone to show. Fall back to the
  customer's own name and mobile, matching the invoice PDF. Applied at both sites.
  
  CustomerController: same empty-IN exposure in the customer order-history batch
  fetch, where a customer whose only order is an insurance sale yields no order
  items. Adds the java.util.HashMap import this file needed (it imports java.util
  members individually).
  
  Verified profitmandi-web compiles clean with these changes. Note trunk currently
  does NOT build: V2FofoPurchaseReturnController:635 still calls the 4-arg
  selectByWarehouseIdsAndDateRange that r37377 widened to 5 args (r37378 updated
  the fofo caller but not this one). That break is untouched here and needs its
  own fix before a web war can be built.