Subversion Repositories SmartDukaan

Last modification

• Rev 37776 2026-09-24 20:16:26
• Author: amit

• Log message:

  returns: reverse a refunded debit-note return whose goods never reached the warehouse
  
  Once a return was refunded nothing could undo it - rejectReturn refuses an already
  refunded one - so a return booked and paid for goods that never arrived left phantom
  warehouse stock, the unit missing from partner stock, the order marked returned, a
  wallet credit and a filed credit note, with no way back.
  
  ReturnReversalService.reverse(imei, reason, by, dryRun) undoes exactly one unit:
  the warehouse return scan (row deleted so a genuine return later is not rejected as a
  duplicate) and the stock it added, partner stock with its schemes/price drop/offers,
  the order's return quantity and status, the wallet refund as a REVERSAL entry, and the
  return item / debit note. Guards refuse anything that has moved since the refund, and a
  dry run reports the plan without writing.
  
  The credit note follows movement and the NIC clock: inside the 24h window, and only
  when the note credits nothing but this unit, its IRN is cancelled and the note marked
  cancelled; past it a DBN with its own IRN is issued against the note
  (CreditNoteService.issueReturnReversalDebitNote, stored as CN_CANCELLATION with no
  margin month so the statement does not show it twice - the wallet REVERSAL is the
  statement line); a note never filed at NIC is voided locally. Every local write happens
  first and NIC last, so a refusal rolls the whole reversal back.
  
  fofo.return_reversal (return_reversal_20260921.sql) records each reversal and, unique
  per return item, makes it once-only. Also adds cancelled=0 to the RETURNS_CN branches of
  the account statement queries, without which a cancelled note keeps crediting the
  statement - no current effect, no RETURNS note is cancelled today.