Subversion Repositories SmartDukaan

Last modification

• Rev 37585 2026-09-10 17:19:06
• Author: amit

• Log message:

  Fix web-offer sync: selectModelOffers join order (Unknown column 'o.id' in 'on clause')
  
  selectModelOffers led its FROM with offers.offer_product p and then joined
  offers.offer_raw_row r ON r.offer_id = o.id, referencing alias o one join
  before o was introduced. An ON clause resolves only against tables already
  in the join order, so MySQL rejected it with SQLSyntaxErrorException:
  Unknown column 'o.id' in 'on clause'. Every per-model sync since r37581 has
  therefore failed - webOfferSync=FAILED on the 15:04 and 17:14 re-ingests of
  document 4 - leaving the 166 legacy NULL-key row-badges active and zero
  consolidated badges published.
  
  Reordered to lead with offers.offer o, matching the proven shape of the
  sibling selectRowOffers query. All three are inner joins so the result set
  is unchanged; BEST_OFFER_WINS and ORDER BY p.catalog_id still resolve.
  
  Verified by executing the corrected statement read-only against prod for
  document 4: 733 rows over 314 distinct catalog ids, the expected model
  count. Not caught by tests because all 53 offercircular tests are
  stub-based (no Spring, no DB) and never execute this SQL.
  
  Failure was visible only because r37568 records webOfferSync= in
  ingest_summary; the runner still swallows the exception by design.