Subversion Repositories SmartDukaan

Last modification

• Rev 37504 2026-09-01 16:59:34
• Author: amit

• Log message:

  Stop invoice read paths creating directories (AccessDeniedException 500s)
  
  getInvoicePath called Files.createDirectories, and getInvoiceFile called it on every
  download. Invoices are generated by the cron app as root, so /SaholicInvoices/<month>
  is 755 root-owned; a download served by Tomcat cannot create a retailer subdirectory
  and threw AccessDeniedException.
  
  It threw on line 1 of getInvoiceFile, before the Files.exists check, so the
  ProfitMandiBusinessException on the next line was unreachable and the callers'
  deliberate 404 handler ("Invoice not yet generated, please retry shortly") never ran.
  Downloads for a not-yet-generated invoice 500ed instead of 404ing - the exact log
  noise that handler was added to remove.
  
  Split the path computation out: resolveInvoicePath is side-effect free and used by
  getInvoiceFile; getInvoicePath keeps the mkdir for the two generation callers
  (InvoiceService:558, GstProService:952). The legacy relocation branch creates the
  target directory only when there is actually a file to move.
  
  No ops change needed - generation as root already works.