WebSVN – SmartDukaan – Diff – /trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/repository/cs/CsServiceImpl.java

     @Override
     public Map<EscalationType, AuthUser> getAuthUserAndEsclationByPartnerId(int fofoId) throws ProfitMandiBusinessException {
         Map<EscalationType, AuthUser> authuserEsclationTypeMap = new HashMap<>();
         List<Integer> regionIds = partnerRegionRepository.selectByfofoId(fofoId).stream().map(x -> x.getRegionId()).collect(Collectors.toList());
-        regionIds.add(5);// All partners Id;
+        regionIds.add(ALL_PARTNERS_REGION);// All partners Id;
         List<Integer> fofoIds = new ArrayList<>();
         fofoIds.add(fofoId);
         fofoIds.add(0);
-        //LOGGER.info("fofoIds" + fofoIds);
         List<Integer> partnerPositionIds = partnerPositionRepository.selectByRegionIdAndPartnerId(regionIds, fofoIds).stream().map(x -> x.getPositionId()).collect(Collectors.toList());
-        //LOGGER.info("partnerPositionIds" + partnerPositionIds);
-        for (Integer partnerPostionId : partnerPositionIds) {
+        if (partnerPositionIds.isEmpty()) {
-            Position position = positionRepository.selectByIdAndCategoryId(partnerPostionId, ProfitMandiConstants.TICKET_CATEGORY_SALES);
-            //LOGGER.info("position" + position);
+            return authuserEsclationTypeMap;
-            if (position != null) {
+        }
-                AuthUser authUser = authRepository.selectById(position.getAuthUserId());
-                //LOGGER.info("authUser" + authUser);
+        // OPTIMIZED: Batch fetch all positions instead of N+1 queries
+        List<Position> salesPositions = positionRepository.selectByIds(partnerPositionIds).stream()
+                .filter(p -> p.getCategoryId() == ProfitMandiConstants.TICKET_CATEGORY_SALES)
+                .collect(Collectors.toList());
+        if (salesPositions.isEmpty()) {
+            return authuserEsclationTypeMap;
+        }
+        // OPTIMIZED: Batch fetch all AuthUsers instead of N+1 queries
+        List<Integer> authUserIds = salesPositions.stream()
+                .map(Position::getAuthUserId)
+                .filter(id -> id != null && id > 0)
+                .distinct()
+                .collect(Collectors.toList());
+        Map<Integer, AuthUser> authUserMap = authRepository.selectByIds(authUserIds).stream()
+                .collect(Collectors.toMap(AuthUser::getId, au -> au, (a, b) -> a));
+        for (Position position : salesPositions) {
+            AuthUser authUser = authUserMap.get(position.getAuthUserId());
+            if (authUser != null) {
                 authuserEsclationTypeMap.put(position.getEscalationType(), authUser);
+            }
+        }
-        //LOGGER.info("emailEsclationTypeMap" + authuserEsclationTypeMap);
         return authuserEsclationTypeMap;
+    }
     @Override
     public Map<Integer, Map<EscalationType, AuthUser>> getAuthUserAndEsclationByPartnerIds(Set<Integer> fofoIds) throws ProfitMandiBusinessException {
+    }
     @Override
     public Map<Integer, TicketCategory> getSubCategoryIdAndCategoryMap(List<Integer> subCategoryIds) {
         Map<Integer, TicketCategory> subCategoryIdAndCategoryMap = new HashMap<>();
+        if (subCategoryIds == null || subCategoryIds.isEmpty()) {
+            return subCategoryIdAndCategoryMap;
+        }
         List<TicketSubCategory> ticketSubCategories = ticketSubCategoryRepository.selectByIds(subCategoryIds);
+        // OPTIMIZED: Batch fetch all categories instead of N+1 queries
-        for (TicketSubCategory ticketSubCategory : ticketSubCategories) {
+        List<Integer> categoryIds = ticketSubCategories.stream()
+                .map(TicketSubCategory::getCategoryId)
+                .distinct()
+                .collect(Collectors.toList());
-            TicketCategory ticketCategory = ticketCategoryRepository.selectById(ticketSubCategory.getCategoryId());
+        Map<Integer, TicketCategory> categoryMap = ticketCategoryRepository.selectAll(categoryIds).stream()
-            subCategoryIdAndCategoryMap.put(ticketSubCategory.getId(), ticketCategory);
+                .collect(Collectors.toMap(TicketCategory::getId, tc -> tc, (a, b) -> a));
+        for (TicketSubCategory ticketSubCategory : ticketSubCategories) {
+            subCategoryIdAndCategoryMap.put(ticketSubCategory.getId(), categoryMap.get(ticketSubCategory.getCategoryId()));
+        }
         return subCategoryIdAndCategoryMap;
+    }
     @Override

Subversion Repositories SmartDukaan

(root)/trunk/profitmandi-dao/src/main/java/com/spice/profitmandi/dao/repository/cs/CsServiceImpl.java – Rev 35563 → 35592