WebSVN – SmartDukaan – Diff – /trunk/PaymentService/src/main/java/in/shop2020/payment/service/handler/PaymentServiceHandler.java

 package in.shop2020.payment.service.handler;
-import in.shop2020.crm.CRMService.Client;
 import in.shop2020.payment.domain.Refund;
 import in.shop2020.payment.handler.PaymentGatewayHandler;
 import in.shop2020.payment.handler.PaymentHandler;
+import in.shop2020.payment.handler.PaymentRequiringExtraProcessingHandler;
 import in.shop2020.payment.handler.RefundHandler;
 import in.shop2020.payments.Attribute;
+import in.shop2020.payments.ExtraPaymentProcessingType;
 import in.shop2020.payments.Payment;
 import in.shop2020.payments.PaymentException;
 import in.shop2020.payments.PaymentGateway;
 import in.shop2020.payments.PaymentService.Iface;
 import in.shop2020.payments.PaymentStatus;
-import in.shop2020.thrift.clients.CRMClient;
 import java.text.SimpleDateFormat;
 import java.util.ArrayList;
 import java.util.Date;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import org.apache.thrift.TException;
-import org.apache.thrift.transport.TTransportException;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.context.ApplicationContext;
 import org.springframework.context.support.ClassPathXmlApplicationContext;
 	private static final long EBS_GATEWAY_ID = 2;
 	private static final long HDFC_EMI_GATEWAY_ID = 5;
 	ApplicationContext context = new ClassPathXmlApplicationContext("context.xml");
 	PaymentHandler paymentHandler = (PaymentHandler) context.getBean("paymentHandler");
+    PaymentRequiringExtraProcessingHandler paymentRequiringExtraProcessingHandler =
+        (PaymentRequiringExtraProcessingHandler) context.getBean("paymentRequiringExtraProcessingHandler");
-	PaymentGatewayHandler paymentGatewayHandler = (PaymentGatewayHandler) context.getBean("paymentGatewayHandler");
+    PaymentGatewayHandler paymentGatewayHandler = (PaymentGatewayHandler) context.getBean("paymentGatewayHandler");
 	RefundHandler refundHandler = (RefundHandler) context.getBean("refundHandler");
 	@Override
 	public long createPayment(long userId, double amount, long gatewayId, long txnId) throws PaymentException, TException {
 	    logger.info("Creating payment corresponding to our txn id:" + txnId);
 			payment.setStatus(status.getValue());
 			if(status.equals(PaymentStatus.SUCCESS))
 				payment.setSuccessTimestamp(new Date());
 			else if(status.equals(PaymentStatus.FAILED)) {
 			    payment.setErrorTimestamp(new Date());
-			    createTicketForFailedPayment(payment);
+			    persistPaymentRequiringExtraProcessing(payment);
+			}
+		}
 		payment.setGatewayTxnDate(gatewayTxnDate);
 		paymentHandler.updatePayment(payment, attrMap);
 		return true;
+	}
 	/**
-	 * Creates a ticket in CRM tool for each customer whose payment got failed.
+	 * Persists a given payment Id in another table for future processing by CRM etc.
-	 * Later, CRM agents follow-up with the users and try making a sale.
+	 * Failed payments generally require a follow-up to help customers through our
-	 *
-	 * We swallow the exceptions raised and just log them at error level. This is
-	 * done to not make Website unaffected by any CRM related issues.
+	 * CRM-Outbound team.
+	 *
 	 * @param payment  the payment object that failed.
 	 */
-	private void createTicketForFailedPayment(in.shop2020.payment.domain.Payment payment) {
+	private void persistPaymentRequiringExtraProcessing(in.shop2020.payment.domain.Payment payment) {
-        try {
+	    try {
-            Client crmClient = new CRMClient().getClient();
-            // This call is aync (oneway). This ensures that website response
-            // is sent in time.
-            crmClient.processPaymentFailure(payment.getUserId());
+            paymentRequiringExtraProcessingHandler.insert(payment.getId(), ExtraPaymentProcessingType.FAILED_PAYMENTS);
-        } catch (TTransportException e) {
-            logger.error("Could not create CRM client", e);
-        } catch (TException e) {
+        } catch (Exception e) {
-            logger.error("Could not process paymentId: " + payment.getId(), e);
+            logger.error("Could not persist payment: " + payment.getId(), e);
+        }
+    }
     @Override
 	public List<Double> getSuccessfulPaymentsAmountRange() throws TException {
             payment.setDescription(description);
             payment.setErrorCode(errorCode);
             payment.setStatus(PaymentStatus.FAILED.getValue());
             payment.setErrorTimestamp(new Date());
             paymentHandler.updatePayment(payment, attrMap);
-            createTicketForFailedPayment(payment);
+            persistPaymentRequiringExtraProcessing(payment);
             return false;
         } else {
             // Success
             logger.info("Capture attempt successful for HDFC payment with id: " + merchantPaymentId);
             payment.setDescription("Payment Captured");
             payment.setDescription(description);
             payment.setErrorCode(errorCode);
             payment.setStatus(PaymentStatus.FAILED.getValue());
             payment.setErrorTimestamp(new Date());
             paymentHandler.updatePayment(payment, attrMap);
-            createTicketForFailedPayment(payment);
+            persistPaymentRequiringExtraProcessing(payment);
             return false;
         } else {
             // Success
             logger.info("Capture attempt successful for HDFC payment with id: " + merchantPaymentId);
             payment.setDescription("Payment Captured");
             payment.setDescription(description);
             payment.setErrorCode(errorCode);
             payment.setStatus(PaymentStatus.FAILED.getValue());
             payment.setErrorTimestamp(new Date());
             paymentHandler.updatePayment(payment, attrMap);
-            createTicketForFailedPayment(payment);
+            persistPaymentRequiringExtraProcessing(payment);
             return false;
         }else{
             //Success
             logger.info("Capture attempt successful for EBS payment with id: " + payment.getId());
             payment.setGatewayTxnStatus(captureStatus);
     @Override
     public void closeSession() throws TException {
         // TODO Auto-generated method stub
+    }
+    @Override
+    public List<Long> getPaymentsRequiringExtraProcessing (
+            ExtraPaymentProcessingType category) throws TException {
+        return paymentRequiringExtraProcessingHandler.getPaymentIds(category);
+    }
+    @Override
+    public void markPaymentAsProcessed(long paymentId,
+            ExtraPaymentProcessingType category) throws TException {
+        paymentRequiringExtraProcessingHandler.delete(paymentId, category);
+    }
+}

Subversion Repositories SmartDukaan

(root)/trunk/PaymentService/src/main/java/in/shop2020/payment/service/handler/PaymentServiceHandler.java – Rev 3956 → 4008